Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored procedures schema and introspection (Incremental PR - I) #142

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

codingkarthik
Copy link
Collaborator

@codingkarthik codingkarthik commented Jul 1, 2024

What

This PR adds introspection and schema support for stored procedures in MSSQL. This PR is the first incremental PR towards adding stored procedures support.

How

Introspection

A database query is made to get all the metadata about stored procedures present in the database. As it is a stored procedure, there is no return type tied to it, so we leave the returns part empty and we expect the user to fill in the appropriate schema.

Schema

We do schema generation for a stored procedure, only if it has a returns associated with it. Otherwise, we won't be able to generate a graphql schema for the stored procedure.

@codingkarthik codingkarthik marked this pull request as ready for review July 1, 2024 08:01
@m-Bilal m-Bilal added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit 5602bb4 Jul 2, 2024
18 checks passed
@m-Bilal m-Bilal deleted the kc/stored-procs-schema-from-rebase-branch branch July 2, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants