Skip to content

Fix: Date picker resetting on close #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix: Date picker resetting on close #1179

merged 1 commit into from
Jan 10, 2025

Conversation

mrkaye97
Copy link
Contributor

Description

Fixing date picker resetting when it's closed

Type of change

  • Bug fix (non-breaking change which fixes an issue)

What's Changed

Two issues here -

  1. The onOpenChange callback was causing the date picker to reset when it was closed. AFAICT, that callback doesn't do anything, so I removed it
  2. The time pickers were using derived state from inside the date picker instead of the selected date, so I removed the derived state and passed the selected date through, which seems to work correctly.

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hatchet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 6:18pm

@mrkaye97 mrkaye97 merged commit a58eb1c into main Jan 10, 2025
30 checks passed
@mrkaye97 mrkaye97 deleted the fix-calendar-filter branch January 10, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants