fix: Server listing static vals + ServerMgr #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the explicit ver should remove the need for the +certs since new versions should already have them. Added cmds via recommended array[] while splitting them on different lines for read clarity and git diff clarity for changes
Greatly simplified code
* Serialized @ HathoraServerMgr instead of Photon's Global settings; more intuitive. * In addddition: Added instructions if accessed but !serialized
Plus: * Added cancel token to Task util to wait until, to prevent stack overflows * Added the Room api to serverMgr * Updated HathoraManager prefab
* Eg: Renamed HathoraNetClient to HathoraClient for consistency; Hathora-Unity already backported * Updated HathoraManager GameObj to match * Replaced HathoraManager GameObj with prefab from base for easier updating
Model With utils for Networking.cs init as server +Minor doc fix for HathoraTaskUtils
* Moved some Hathora Networking.cs tasks way earlier; we needed to intercept SessionRequest before it turned into Session (to set lobby name, max players, etc - everything from InitialConfig prop) * Fixed Singleton false positive get err
DF == Dockerfile
+Err catch with better instructions
/feat/dockerfile-update
hathora mgr is only in the Menu scene. If we start from another scene, things break? Keep an eye on this.
We were initializing the same way we did for Monobehaviour, at some point inadvertently. Servers init via constructor (client mgr inits via Init func)
Notably: * There was a special Property setting util we didn't set * GameMode on Create was saved as "Host" instead of "Server" Plus: * Impr mock procId debugger * Tweaks, prettify, docs, minor refactoring
* Deleted "Auto" Region * Bumped "USA, East" to the top * Curiously: We can edit other Region settings here. Revisit this later?
Easy to port this over without it
# Conflicts: # .hathora/Dockerfile # Assets/Hathora/Core/Scripts/Editor/Server/HathoraDocker.cs
Among some docs and consistency changes
TODOSince this PR is still open, we may as well parity up with the related changes from hathora-unity:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core Fix
When creating a 25-player room named "Player39954's Game" --
Before
After
^ Also fixed the bottom-right 'created' to match the name (rather than id).
Additionally