Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrades eslint to v9 and migrate to flat config #870 #1148

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

phantomjinx
Copy link
Member

  • Conversion of .eslintrc.js to eslint.config.mjs

  • Incorporation of .eslintignore into config file

  • Upgrades eslint package and respective plugins

  • eslint.config.mjs

  • Some plugins are still not eslint 9 compatible so the compat library is used as a go-between

  • [*.ts, *.js]

  • Updates to satisfy new warnings produced by running yarn lint

@phantomjinx
Copy link
Member Author

Some of these resolutions to warnings, eg. eslint-disable comments removed, seem a little unsettling but they 'seem' to be the right course of action. Anyway, please review and we can take further iterations to get this right.

Note: eslint plugins such as testing-library and react-hooks are not fully compliant with eslint v9.

* Conversion of .eslintrc.js to eslint.config.mjs

* Incorporation of .eslintignore into config file

* Upgrades eslint package and respective plugins

* eslint.config.mjs
 * Some plugins are still not eslint 9 compatible so the compat library is
   used as a go-between

* [*.ts, *.js]
 * Updates to satisfy new warnings produced by running `yarn lint`
@hawtio-ci
Copy link

hawtio-ci bot commented Oct 7, 2024

Test results

Run attempt: 2464
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
test-results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 332.536
test-results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 343.99
test-results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 336.666
test-results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 336.324
test-results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 333.417
test-results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 352.593
test-results-springboot-node(20)-java(17)-firefox 67 63 4 0 0 335.02
test-results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 331.286

Copy link

github-actions bot commented Oct 7, 2024

Test Results

  8 files  ±0    8 suites  ±0   45m 1s ⏱️ +2s
 66 tests ±0   64 ✅ ±0   2 💤 ±0  0 ❌ ±0 
536 runs  ±0  508 ✅ ±0  28 💤 ±0  0 ❌ ±0 

Results for commit 1f58ebc. ± Comparison against base commit caec81e.

♻️ This comment has been updated with latest results.

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@tadayosi tadayosi merged commit b6c6e5d into hawtio:main Oct 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants