Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr 1185 fix #1190

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Pr 1185 fix #1190

merged 4 commits into from
Nov 14, 2024

Conversation

grgrzybek
Copy link
Contributor

No description provided.

dependabot bot and others added 2 commits October 24, 2024 10:52
Bumps [keycloak-js](https://github.com/keycloak/keycloak) from 23.0.7 to 26.0.2.
- [Release notes](https://github.com/keycloak/keycloak/releases)
- [Commits](keycloak/keycloak@23.0.7...26.0.2)

---
updated-dependencies:
- dependency-name: keycloak-js
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link

github-actions bot commented Oct 28, 2024

Test Results

  8 files  ±0    8 suites  ±0   57m 27s ⏱️ -40s
 66 tests ±0   64 ✅ ±0   2 💤 ±0  0 ❌ ±0 
536 runs  ±0  508 ✅ ±0  28 💤 ±0  0 ❌ ±0 

Results for commit b17ad7e. ± Comparison against base commit 00e67c9.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented Oct 28, 2024

Test results

Run attempt: 2610
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
test-results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 428.342
test-results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 438.61
test-results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 424.998
test-results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 425.476
test-results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 435.999
test-results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 430.335
test-results-springboot-node(20)-java(17)-firefox 67 63 4 0 0 433.553
test-results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 430.466

@grgrzybek
Copy link
Contributor Author

keycloak/keycloak#33080 broke Jest tests, because in keycloak-js <=25 we had:

"exports": {
  ".": {
    "import": {
      "types": "./dist/keycloak.d.mts",
      "default": "./dist/keycloak.mjs"
    },
    "require": {
      "types": "./dist/keycloak.d.ts",
      "default": "./dist/keycloak.js"
    }
  },
},

and in 26+ we have:

"exports": {
  ".": {
    "types": "./lib/keycloak.d.ts",
    "default": "./lib/keycloak.js"
  },
},

Thanks to the mjs extension, Jest was working well with ESM code and now ESM code is used in js file, which breaks Jest...

cc: @tadayosi

@tadayosi tadayosi merged commit 072cb39 into main Nov 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants