Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): enable auto-connect based on preset connections from backend #1286

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

tadayosi
Copy link
Member

@tadayosi tadayosi commented Jan 6, 2025

Required by hawtio/hawtio#3731

This enhancement introduces support for the new backend API /preset-connections which can return a set of preset connections from the Hawtio CLI --connection option and automatically connecting to them.

Copy link

github-actions bot commented Jan 6, 2025

Test Results

  8 files  ±0    8 suites  ±0   1h 3m 15s ⏱️ - 1m 26s
 67 tests ±0   65 ✅ ±0   2 💤 ±0  0 ❌ ±0 
544 runs  ±0  516 ✅ ±0  28 💤 ±0  0 ❌ ±0 

Results for commit 2ef4654. ± Comparison against base commit eecda33.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented Jan 6, 2025

Test results

Run attempt: 3056
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
test-results-quarkus-node(18)-java(17)-firefox 68 65 3 0 0 482.49
test-results-quarkus-node(18)-java(21)-firefox 68 65 3 0 0 473.73
test-results-quarkus-node(20)-java(17)-firefox 68 65 3 0 0 478.6
test-results-quarkus-node(20)-java(21)-firefox 68 65 3 0 0 476.18
test-results-springboot-node(18)-java(17)-firefox 68 64 4 0 0 472.026
test-results-springboot-node(18)-java(21)-firefox 68 64 4 0 0 473.275
test-results-springboot-node(20)-java(17)-firefox 68 64 4 0 0 469.318
test-results-springboot-node(20)-java(21)-firefox 68 64 4 0 0 470.195

@tadayosi tadayosi requested a review from grgrzybek January 6, 2025 08:44
…ection

It also avoids failing to auto-connect to an authenticated preset
connection in the primary tab by reloading the primary tab with ?con=
parameter instead of resolving the conn ID asynchronously internally.

hawtio/hawtio#3731
@tadayosi tadayosi force-pushed the issue-3731-cli-connection branch from 3750134 to 0b149bb Compare January 7, 2025 08:56
@tadayosi tadayosi merged commit 39ed52d into hawtio:main Jan 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants