Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stringSorter): Compare lowercase strings to prevent incorrect string ordering. #681

Merged
merged 1 commit into from
Nov 24, 2023
Merged

fix(stringSorter): Compare lowercase strings to prevent incorrect string ordering. #681

merged 1 commit into from
Nov 24, 2023

Conversation

mmelko
Copy link
Collaborator

@mmelko mmelko commented Nov 23, 2023 •
edited by tadayosi
Loading

fix HAWNG-7

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited
Loading

Test Results

    8 files  ±0      8 suites  ±0   40m 50s ⏱️ ±0s
  59 tests ±0    58 ✔️ ±0  1 💤 ±0  0 ❌ ±0 
468 runs  ±0  460 ✔️ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit d44e208. ± Comparison against base commit a23b6c5.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented Nov 23, 2023 •
edited
Loading

Test results

Run attempt: 842
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(11)-firefox 59 58 1 0 0 313.817
results-quarkus-node(18)-java(17)-firefox 59 58 1 0 0 312.306
results-quarkus-node(20)-java(11)-firefox 59 58 1 0 0 311.706
results-quarkus-node(20)-java(17)-firefox 59 58 1 0 0 306.397
results-springboot-node(18)-java(11)-firefox 58 57 1 0 0 303.216
results-springboot-node(18)-java(17)-firefox 58 57 1 0 0 300.032
results-springboot-node(20)-java(11)-firefox 58 57 1 0 0 296.821
results-springboot-node(20)-java(17)-firefox 58 57 1 0 0 306.646

tadayosi

This comment was marked as duplicate.

Sign in to view

tadayosi
tadayosi requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me block merge of this until we can resolve the remaining questions on it.

tadayosi
tadayosi approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. could you write tests for the new stringSorter?

@mmelko
fix(stringSorter): Use localeCompare in the stringSorter to prevent i…
d44e208 
…ncorrect sorting when mixed case

fix HAWNG-7
@tadayosi tadayosi merged commit 3bce079 into hawtio:main Nov 24, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@tadayosi tadayosi tadayosi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmelko @tadayosi @oscerd