Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Runtime-plugin): refactor filtering in Threads and SysProps components #682

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

mmelko
Copy link
Collaborator

@mmelko mmelko commented Nov 24, 2023

This PR is essentially move handleSearch logic into the separate useEffect. This reduces little bit a complexity and improves readability.

Copy link

Test Results

    8 files  ±0      8 suites  ±0   40m 36s ⏱️ -19s
  59 tests ±0    58 ✔️ ±0  1 💤 ±0  0 ±0 
468 runs  ±0  460 ✔️ ±0  8 💤 ±0  0 ±0 

Results for commit dff4385. ± Comparison against base commit 3bce079.

@hawtio-ci
Copy link

hawtio-ci bot commented Nov 24, 2023

Test results

Run attempt: 844
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(11)-firefox 59 58 1 0 0 302.583
results-quarkus-node(18)-java(17)-firefox 59 58 1 0 0 306.956
results-quarkus-node(20)-java(11)-firefox 59 58 1 0 0 303.237
results-quarkus-node(20)-java(17)-firefox 59 58 1 0 0 309.994
results-springboot-node(18)-java(11)-firefox 58 57 1 0 0 305.515
results-springboot-node(18)-java(17)-firefox 58 57 1 0 0 300.593
results-springboot-node(20)-java(11)-firefox 58 57 1 0 0 304.437
results-springboot-node(20)-java(17)-firefox 58 57 1 0 0 303.166

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@tadayosi tadayosi merged commit 0546a6b into hawtio:main Nov 25, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants