Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(springboot-plugin):fix exceptions when rendering components #723

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

mmelko
Copy link
Collaborator

@mmelko mmelko commented Dec 19, 2023

This PR is fixing hawtio/hawtio-online#270

by refactoring the Health component in the spring-boot plugin. Previously there was a Record to determine the corrent spans for the components, however in the openshift there is more probe components that was throwing exception.

Now I introduced just list of the components that have 'fixed' position and rest is rendered underneath:
image

image

image

Copy link
Member

@phantomjinx phantomjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It solves the problem nicely but maybe consider my comments to further tighten it up?

packages/hawtio/src/plugins/springboot/Health.tsx Outdated Show resolved Hide resolved
packages/hawtio/src/plugins/springboot/Health.tsx Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Dec 19, 2023

Test Results

    8 files  +    7      8 suites  +7   40m 54s ⏱️ + 36m 3s
  59 tests ±    0    58 ✔️ ±    0  1 💤 ±0  0 ±0 
468 runs  +409  460 ✔️ +402  8 💤 +7  0 ±0 

Results for commit c174844. ± Comparison against base commit f1fa3d1.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented Dec 19, 2023

Test results

Run attempt: 958
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(11)-firefox 59 58 1 0 0 305.267
results-quarkus-node(18)-java(17)-firefox 59 58 1 0 0 311.58
results-quarkus-node(20)-java(11)-firefox 59 58 1 0 0 320.907
results-quarkus-node(20)-java(17)-firefox 59 58 1 0 0 313.158
results-springboot-node(18)-java(11)-firefox 58 57 1 0 0 290.476
results-springboot-node(18)-java(17)-firefox 58 57 1 0 0 286.77
results-springboot-node(20)-java(11)-firefox 58 57 1 0 0 320.513
results-springboot-node(20)-java(17)-firefox 58 57 1 0 0 305.852

@phantomjinx phantomjinx merged commit 0808b2b into hawtio:main Dec 19, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants