Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): cannot add productInfo to hawtconfig when about is absent #789

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix(core): cannot add productInfo to hawtconfig when about is absent #789

merged 1 commit into from
Feb 20, 2024

Conversation

tadayosi
Copy link
Member

Fix #715

phantomjinx
phantomjinx approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@phantomjinx phantomjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Test Results

  8 files  ±0    8 suites  ±0   41m 14s ⏱️ -7s
 59 tests ±0   58 ✅ ±0  1 💤 ±0  0 ❌ ±0 
468 runs  ±0  460 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 6380d19. ± Comparison against base commit 08034bf.

@hawtio-ci
Copy link

hawtio-ci bot commented Feb 20, 2024

Test results

Run attempt: 1166
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(11)-firefox 59 58 1 0 0 332.368
results-quarkus-node(18)-java(17)-firefox 59 58 1 0 0 300.82
results-quarkus-node(20)-java(11)-firefox 59 58 1 0 0 299.684
results-quarkus-node(20)-java(17)-firefox 59 58 1 0 0 321.618
results-springboot-node(18)-java(11)-firefox 58 57 1 0 0 302.213
results-springboot-node(18)-java(17)-firefox 58 57 1 0 0 290.73
results-springboot-node(20)-java(11)-firefox 58 57 1 0 0 301.983
results-springboot-node(20)-java(17)-firefox 58 57 1 0 0 325.373

@tadayosi tadayosi merged commit 47d7d15 into hawtio:main Feb 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phantomjinx phantomjinx phantomjinx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConfigManager expects at least an empty [] in hawtconfig.json
2 participants
@tadayosi @phantomjinx