Skip to content

Commit

Permalink
Do not use different versionCodes when building bundleApks
Browse files Browse the repository at this point in the history
  • Loading branch information
hughsando committed Jul 10, 2024
1 parent f08444f commit 615c072
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions templates/android/PROJ-gradle/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ dependencies {
}
}

::if !NME_BUNDLE_RELEASE::
/* Assigns a different version code for each output APK
other than the universal APK. */

Expand All @@ -140,3 +141,4 @@ android.applicationVariants.all { variant ->
}
}
}
::end::
1 change: 1 addition & 0 deletions tools/nme/src/CommandLineTools.hx
Original file line number Diff line number Diff line change
Expand Up @@ -1067,6 +1067,7 @@ class CommandLineTools
{
if (project.command!="uploadcrashlytics")
project.command = "build";
project.androidConfig.bundleApk = true;
}
words.splice(w,1);
break;
Expand Down
1 change: 1 addition & 0 deletions tools/nme/src/platforms/AndroidPlatform.hx
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,7 @@ class AndroidPlatform extends Platform

context.ABIS = [for(abi in includedABIs()) '"${abi.name}"'].join(', ');
context.ABI_CODES = [for(abi in includedABIs()) '\'${abi.name}\':${abi.versionCodeScaler}'].join(', ');
context.NME_BUNDLE_RELEASE = project.androidConfig.bundleApk;
}

function getNdkStackExe()
Expand Down
2 changes: 2 additions & 0 deletions tools/nme/src/project/NMEProject.hx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class AndroidConfig
public var minApiLevel:Int;
public var addV4Compat:Bool;
public var universalApk:Bool;
public var bundleApk:Bool;
public var targetApiLevel:Null<Int>;
public var buildApiLevel:Null<Int>;
public var appHeader:Array<String>;
Expand All @@ -34,6 +35,7 @@ class AndroidConfig
minApiLevel = 21;
addV4Compat = false;
universalApk = false;
bundleApk = false;
appHeader = [];
appIntent = [];
appActivity = [];
Expand Down

0 comments on commit 615c072

Please sign in to comment.