Skip to content

feat: allow prismaFilters to filter for null values with not #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

chenzn1
Copy link
Contributor

@chenzn1 chenzn1 commented Nov 2, 2023

isNot is used only for relation filter conditions.

Copy link

changeset-bot bot commented Nov 2, 2023

🦋 Changeset detected

Latest commit: 4a11ce0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@pothos/plugin-prisma-utils Minor
@pothos-examples/complex-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pothos ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 6:26am

@chenzn1
Copy link
Contributor Author

chenzn1 commented Nov 6, 2023

@hayes Can you merge this?

@hayes
Copy link
Owner

hayes commented Nov 6, 2023

It looks like tests are failing and the PR is missing a changeset

@hayes
Copy link
Owner

hayes commented Nov 6, 2023

In the middle of moving, so can't fix this myself tonight, but might have some time tomorrow

@chenzn1
Copy link
Contributor Author

chenzn1 commented Nov 6, 2023

It looks like tests are failing and the PR is missing a changeset

The test error existed before, i cant try to fix it.

@chenzn1 chenzn1 closed this Nov 6, 2023
@chenzn1 chenzn1 reopened this Nov 6, 2023
@@ -24,7 +24,7 @@ describe('prisma utils', () => {
query {
posts(
order: { author: { name: Desc, profile: null } }
filter: { id: { not: { equals: 11, not: null } } }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this need to be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the id field not be null

Copy link
Contributor Author

@chenzn1 chenzn1 Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Prisma only allow use null filter on null field, such as the content field

@hayes
Copy link
Owner

hayes commented Nov 6, 2023

Thanks for adding the changeset!

@hayes
Copy link
Owner

hayes commented Nov 6, 2023

thanks for the fix!

@hayes hayes merged commit cb4afca into hayes:main Nov 6, 2023
@chenzn1 chenzn1 deleted the feature/prisma-filters branch November 28, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants