-
-
Notifications
You must be signed in to change notification settings - Fork 168
feat: allow prismaFilters to filter for null values with not #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 4a11ce0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@hayes Can you merge this? |
It looks like tests are failing and the PR is missing a changeset |
In the middle of moving, so can't fix this myself tonight, but might have some time tomorrow |
The test error existed before, i cant try to fix it. |
@@ -24,7 +24,7 @@ describe('prisma utils', () => { | |||
query { | |||
posts( | |||
order: { author: { name: Desc, profile: null } } | |||
filter: { id: { not: { equals: 11, not: null } } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this need to be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because the id
field not be null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the changeset! |
thanks for the fix! |
isNot
is used only for relation filter conditions.