-
Notifications
You must be signed in to change notification settings - Fork 9
PULL_REQUEST_TEMPLATE
Herbert Rocha edited this page Dec 20, 2018
·
1 revision
Please include a summary of the your pull request. Please also include relevant motivation and context. List any dependencies that are required for this change.
- Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
- Make sure you are making a pull request against the canary branch (left side). Also you should start your branch off our canary.
- Check the commit's or even all commits' message styles matches our requested structure.
- Check your code additions will fail neither code linting checks nor unit test.
Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
- Test A
- Test B
- My code follows the style guidelines of this project
- I have performed a self-review of my own code
- I have commented my code, particularly in hard-to-understand areas
- I have made corresponding changes to the documentation
- My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature works
- New and existing unit tests pass locally with my changes
- Any dependent changes have been merged and published in downstream modules
Thank you!