Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore packages with commit instead of version #8
base: main
Are you sure you want to change the base?
Ignore packages with commit instead of version #8
Changes from 1 commit
7d309be
44d7e69
e860ceb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 102 in lib/spm_version_updates/plugin.rb
lib/spm_version_updates/plugin.rb#L101-L102
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (testing): Test case 'Up to next major but null version' lacks assertions for specific warnings.
Please add assertions to verify that the correct warnings are generated when the version is null. This will ensure that the new logic in
warn_for_new_versions_range
andwarn_for_new_versions
is correctly handling null or invalid versions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (testing): Consider adding more test cases for error handling in version parsing.
Given the changes in error handling for version parsing in
warn_for_new_versions_range
andwarn_for_new_versions
, it would be beneficial to include tests that trigger and verify the handling ofArgumentError
.