Skip to content

Modify health check and add redpanda dependency #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Modify health check and add redpanda dependency #217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ services:
- --schema-registry-addr internal://0.0.0.0:8081,external://0.0.0.0:18081
- --rpc-addr redpanda:33145
- --advertise-rpc-addr redpanda:33145
# When removing this see the comments in the health check
- --mode dev-container
- --smp 1
- --default-log-level=info
Expand All @@ -46,7 +47,9 @@ services:
- REDPANDA_SUPERUSER_USERNAME=${REDPANDA_ADMIN_USER}
- REDPANDA_SUPERUSER_PASSWORD=${REDPANDA_ADMIN_PWD}
healthcheck:
test: ['CMD', 'rpk', 'cluster', 'info', '-X', 'user=${REDPANDA_ADMIN_USER}', '-X', 'pass=${REDPANDA_ADMIN_PWD}']
# Uncomment the line below if you remove the `--mode dev-container`
# test: ['CMD', 'rpk', 'cluster', 'info', '-X', 'user=${REDPANDA_ADMIN_USER}', '-X', 'pass=${REDPANDA_ADMIN_PWD}']
Copy link
Contributor

@lexiv0re lexiv0re Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it working for you when you remove --mode dev-container? For me it's failing either way:

"ExitCode": 1,
					"Output": "unable to request metadata: ILLEGAL_SASL_STATE: Request is not valid given the current SASL state.\n"

Copy link
Contributor Author

@mcquenji mcquenji Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i haven't tested the commented out healthcheck, as it was the previous check you provided. the new health check for --mode dev-container works on my deployment

test: ['CMD', 'rpk', 'cluster', 'info'] # Remove this when not using `--mode dev-container`
interval: 10s
timeout: 5s
retries: 10
Expand Down Expand Up @@ -114,6 +117,8 @@ services:
- LAST_NAME_FIRST=${LAST_NAME_FIRST:-true}
- QUEUE_CONFIG=redpanda:9092
restart: unless-stopped
depends_on:
- redpanda
networks:
- huly_net

Expand Down