Merge pull request #201 from hcodes/fix_typeerror

Fix TypeError
hcodes · Nov 12, 2023 · ef9f71e · ef9f71e
2 parents 44919c5 + e113351
commit ef9f71e
Show file tree

Hide file tree

Showing 7 changed files with 855 additions and 437 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Changelog
 
+## v10.0.1
+- Fix `TypeError: Cannot read properties of undefined (reading 'length')` #199
+
 ## v10.0.0
 - Update major `yandex-speller` package.
 - Remove unsupported options of new API Yandex Speller: `flagLatin`, `ignoreLatin`, `byWords`, `ignoreRomanNumerals` and `ignoreUppercase`.

diff --git a/README.md b/README.md
@@ -217,8 +217,6 @@ To run the linter:<br/>
 | `ignoreText` | `Array` | [`--ignore-text`](#--ignore-text-regexp) |
 | `ignoreCapitalization` | `Boolean` | [`--ignore-capitalization`](#--ignore-capitalization) |
 | `ignoreDigits` | `Boolean` | [`--ignore-digits`](#--ignore-digits) |
-(#--ignore-roman-numerals) |
-| `ignoreUppercase` | `Boolean` | [`--ignore-uppercase`](#--ignore-uppercase) |
 | `ignoreUrls` | `Boolean` | [`--ignore-urls`](#--ignore-urls) |
 | `maxRequests` | `Number` | [`--max-requests`](#--max-requests-value) |
 

diff --git a/lib/tasks.js b/lib/tasks.js
@@ -21,6 +21,31 @@ function onResource(err, data, originalText) {
         data.data = dictionary.removeDictionaryWordsFromData(data.data);
         data.data = yaspeller.removeDuplicates(data.data);
 
+        /* TODO: Incorrect API response
+            1. Japanese and Chinese characters are not supported.
+            2. In response with code ERROR_TOO_MANY_ERRORS, the whole text is returned instead of the word.
+
+            {
+            "err": false,
+            "data": [
+                {
+                "code": 4,
+                "pos": 0,
+                "row": 0,
+                "col": 0,
+                "len": 10,
+                "word": " こんにちは、世界!",
+                "s": [
+                    " こんにちは、世界!"
+                ]
+                }
+            ]
+            }
+
+            Temporarily ignoring this type of error.
+        */
+        data.data = yaspeller.filterIncorrectTypos(data.data);
+
         yaspeller.addPositions(originalText, data.data);
         yaspeller.sortByPositions(data.data);
 

diff --git a/lib/yaspeller.js b/lib/yaspeller.js
@@ -532,7 +532,15 @@ function getErrors() {
         });
 }
 
+function filterIncorrectTypos(data) {
+    return data.filter(item => {
+        const isIncorrectTypo = Boolean(item.code === yaspellerApi.ERROR_TOO_MANY_ERRORS && item.word);
+        return !isIncorrectTypo;
+    });
+}
+
 module.exports = {
+    filterIncorrectTypos,
     addPositions,
     errors: getErrors(),
     checkFile,