Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added link_data --> clear_cache relationship to support repacking zarr nwbfiles #215

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

pauladkisson
Copy link

@pauladkisson pauladkisson commented Aug 21, 2024

Motivation

See catalystneuro/neuroconv#1003

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@pauladkisson
Copy link
Author

@oruebel, can you enable tests for this PR as well?

@pauladkisson
Copy link
Author

@rly @oruebel CI tests pls?

@pauladkisson
Copy link
Author

@rly @oruebel CI tests pls?

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.53%. Comparing base (0355a0c) to head (402d493).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #215      +/-   ##
==========================================
- Coverage   87.13%   85.53%   -1.61%     
==========================================
  Files           5        5              
  Lines        1174     1182       +8     
  Branches      287      291       +4     
==========================================
- Hits         1023     1011      -12     
- Misses        100      115      +15     
- Partials       51       56       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pauladkisson
Copy link
Author

Looks like this is passing all the tests, can we merge?

@rly @oruebel

@oruebel
Copy link
Contributor

oruebel commented Sep 18, 2024

@rly @mavaylon1 can you please review. Export is more your area of expertise

@mavaylon1
Copy link
Contributor

@pauladkisson @oruebel @rly I can take a gander this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants