Fix docker compose files for frontend

healthy-food-and-dietary-products · Jan 29, 2024 · 944dfdb · 944dfdb
1 parent 2755817
commit 944dfdb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/infra/docker-compose.local.yml b/infra/docker-compose.local.yml
@@ -24,16 +24,15 @@ services:
       - ./.env
 
   frontend:
-    # Settings for building image from a cloned frontend repository
-    # build: 
-    #   context: ../../frontend/
-    #   args:
-    #     - VITE_API_URL=${VITE_API_URL}
-    #     - VITE_BASE_URL=${VITE_BASE_URL}
+    # Settings for building image from a cloned frontend repository (mind the branch)
+    build:
+      context: ../../frontend/
+      args:
+        - VITE_API_URL=${VITE_API_URL}
+        - VITE_BASE_URL=${VITE_BASE_URL}
+    # if we need a specific image name after building
+    # or want to pull a specific image from DockerHub (in this case comment lines 28-32)
     image: healthyfoodapi/good_food_frontend:v.01
-    environment:
-      - VITE_API_URL=${VITE_API_URL}
-      - VITE_BASE_URL=${VITE_BASE_URL}
     container_name: good_food_frontend
     command: cp -r /app/dist/. /frontend_static/
     volumes:

diff --git a/infra/docker-compose.yml b/infra/docker-compose.yml
@@ -25,9 +25,6 @@ services:
 
   frontend:
     image: healthyfoodapi/good_food_frontend:v.01
-    environment:
-      - VITE_API_URL=${VITE_API_URL}
-      - VITE_BASE_URL=${VITE_BASE_URL}
     container_name: good_food_frontend
     command: cp -r /app/dist/. /frontend_static/
     volumes: