Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows specifying a directory to the provider configuration #18

Merged
merged 1 commit into from
Apr 15, 2014
Merged

Allows specifying a directory to the provider configuration #18

merged 1 commit into from
Apr 15, 2014

Conversation

achingbrain
Copy link
Contributor

This attempts to address #12 by adding a directory parameter to the provider options. The example in the readme would mean that mongoose-attachments does any ImageMagick related transformations in os.tmpdir(), then mongoose-attachments-localfs would move the transformed image into /absolute/path/to/public/images.

I've also added unit tests with code coverage for the above. To run the tests do:

npm test

..and open coverage/lcov-report/index.html to see the report.

bithavoc pushed a commit that referenced this pull request Apr 15, 2014
Allows specifying a directory to the provider configuration
@bithavoc bithavoc merged commit ffcb8ce into heapsource:master Apr 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants