Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Up-for-discussion: change node-imagemagick dependency to GM + more #49

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Up-for-discussion: change node-imagemagick dependency to GM + more #49

wants to merge 29 commits into from

Commits on Sep 14, 2014

  1. Use custom imagemagick.

    @nathankot
    nathankot committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    1a12ccb View commit details
    Browse the repository at this point in the history

  2. Use git url.

    @nathankot
    nathankot committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    0614472 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2014

  1. Added the filenameId attribute. 

    filenameId allows the user to customize the filename.
Before: /dir/objectId-original.jpg
Now: /dir/<custom-model-attribute>-original.jog
    @SeyZ @nathankot
    SeyZ authored and nathankot committed Nov 1, 2014
    Configuration menu
    Copy the full SHA
    42d3ae2 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2014

  1. Merge branch 'wedis' 

    Conflicts:
	lib/attachments.js
    @nathankot
    nathankot committed Nov 2, 2014
    Configuration menu
    Copy the full SHA
    eacb68f View commit details
    Browse the repository at this point in the history

  2. Add gm dependency.

    @nathankot
    nathankot committed Nov 2, 2014
    Configuration menu
    Copy the full SHA
    e6f6d36 View commit details
    Browse the repository at this point in the history

  3. Tabs to spaces.

    @nathankot
    nathankot committed Nov 2, 2014
    Configuration menu
    Copy the full SHA
    8736cfe View commit details
    Browse the repository at this point in the history

  4. Setup testing.

    @nathankot
    nathankot committed Nov 2, 2014
    Configuration menu
    Copy the full SHA
    6607e9d View commit details
    Browse the repository at this point in the history

  5. Formatting.

    @nathankot
    nathankot committed Nov 2, 2014
    Configuration menu
    Copy the full SHA
    2d27ca9 View commit details
    Browse the repository at this point in the history

  6. Watch script.

    @nathankot
    nathankot committed Nov 2, 2014
    Configuration menu
    Copy the full SHA
    8835f49 View commit details
    Browse the repository at this point in the history

  7. Bootstrap - make it work with watch.

    @nathankot
    nathankot committed Nov 2, 2014
    Configuration menu
    Copy the full SHA
    9050409 View commit details
    Browse the repository at this point in the history

  8. Expose providersRegistry.

    @nathankot
    nathankot committed Nov 2, 2014
    Configuration menu
    Copy the full SHA
    4255f88 View commit details
    Browse the repository at this point in the history

  9. Ensure that the provider actually writes the new file.

    @nathankot
    nathankot committed Nov 2, 2014
    Configuration menu
    Copy the full SHA
    35ca518 View commit details
    Browse the repository at this point in the history

  10. Thumbnail should be smaller.

    @nathankot
    nathankot committed Nov 2, 2014
    Configuration menu
    Copy the full SHA
    99c53ed View commit details
    Browse the repository at this point in the history

  11. Add test for resampling.

    @nathankot
    nathankot committed Nov 2, 2014
    Configuration menu
    Copy the full SHA
    a379528 View commit details
    Browse the repository at this point in the history

  12. Reorganise specs.

    @nathankot
    nathankot committed Nov 2, 2014
    Configuration menu
    Copy the full SHA
    997a508 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2014

  1. README first - tweak how attachment configuration looks.

    @nathankot
    nathankot committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    f6a5ae4 View commit details
    Browse the repository at this point in the history

  2. Tweak the spec.

    @nathankot
    nathankot committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    08c1772 View commit details
    Browse the repository at this point in the history

  3. Code clean up.

    @nathankot
    nathankot committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    7c9c252 View commit details
    Browse the repository at this point in the history

  4. If spacing.

    @nathankot
    nathankot committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    5b18829 View commit details
    Browse the repository at this point in the history

  5. Main functionality is now working using gm.

    @nathankot
    nathankot committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    4b33166 View commit details
    Browse the repository at this point in the history

  6. Restructure and cleanup.

    @nathankot
    nathankot committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    cae2508 View commit details
    Browse the repository at this point in the history

  7. testFindImageMagickFormats belongs simply in test_formats.js

    @nathankot
    nathankot committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    fa5b4bf View commit details
    Browse the repository at this point in the history

  8. Revert "testFindImageMagickFormats belongs simply in test_formats.js" 

    This reverts commit fa5b4bf.
    @nathankot
    nathankot committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    5734f76 View commit details
    Browse the repository at this point in the history

  9. Remove logic that derives logic from imagemagick - seems overkill

    @nathankot
    nathankot committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    44e47fd View commit details
    Browse the repository at this point in the history

  10. Support for non-image files.

    @nathankot
    nathankot committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    7b13f13 View commit details
    Browse the repository at this point in the history

  11. Remove imagemagick dependency.

    @nathankot
    nathankot committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    b3d25ff View commit details
    Browse the repository at this point in the history

  12. Remove some stuff.

    @nathankot
    nathankot committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    6137822 View commit details
    Browse the repository at this point in the history

  13. Need to prefix storage style path with slash.

    @nathankot
    nathankot committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    e5abb58 View commit details
    Browse the repository at this point in the history

  14. Subclass gm, dont mix image objects.

    @nathankot
    nathankot committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    939cf94 View commit details
    Browse the repository at this point in the history