Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited the email regex in config/initializers to remove a multiline a… #5723

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikeh-dev
Copy link

Environment
Ruby 3.1.2
Rails 7.0.7
Devise 4.9.4
Current behaviour
I ran into a failing test with Rspec on the valid email check

The original regex here;

config.email_regexp =/^([\w.%+-]+)@([\w-]+.)+([\w]{2,})$/i

was failing on a new line error

Solution
I corrected to

/\A([\w.%+-]+)@([\w-]+.)+([\w]{2,})\z/i

Basically the same but changing the start and end removed the multiline anchors error for me.
OLD uses ^ and $: Matches start/end of any line
NEW uses \A and \z: Matches start/end of entire string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant