Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix price alert #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix price alert #100

wants to merge 1 commit into from

Conversation

samparsky
Copy link
Contributor

Fix query

@samparsky samparsky changed the title Fix price alert WIP Fix price alert Apr 19, 2018
esco
esco requested changes Apr 20, 2018
View reviewed changes
Copy link
Member

@esco esco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good so far, just a few changes

server/models/alert.js Outdated
userId = new ObjectID(userId)

const query = (fsym) ? {where: {fsym, userId}} : {where: {userId}}
console.log('query', query)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protip: console.log({ query }) for faster debugging

server/models/alert.js Outdated

Alert.fetchAll = async function(access_token, {fsym}=data, cb) {
let err = null
if (!access_token || !access_token.userId) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the ACL json for $owner? Owner checks to see if the userId passed in the url is the same as the one on the accesstoken

server/models/alert.js Outdated

Alert.disable = async function(accessToken, {alertId}=data, cb){
let err = null
if (!accessToken || !accessToken.userId) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$owner

server/models/alert.js Outdated

Alert.enable = async function(accessToken, {alertId}=data, cb){
let err = null
if (!accessToken || !accessToken.userId) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$owner

@samparsky samparsky changed the title WIP Fix price alert Fix price alert Apr 23, 2018
@samparsky samparsky force-pushed the fix-price-alert branch 3 times, most recently from 17e47b9 to 44f1258 Compare April 25, 2018 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esco esco esco requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samparsky @esco