fix by review

helintongh · Jun 20, 2024 · bd1fc40 · bd1fc40
1 parent c18c875
commit bd1fc40
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/include/cinatra/coro_http_client.hpp b/include/cinatra/coro_http_client.hpp
@@ -1590,12 +1590,9 @@ class coro_http_client : public std::enable_shared_from_this<coro_http_client> {
 
 #ifdef CINATRA_ENABLE_BROTLI
       if (encoding_type_ == content_encoding::br) {
-        std::string unbr_str;
-        bool r = br_codec::brotli_decompress(reply, unbr_str);
-        if (r) {
-          data.resp_body = unbr_str;
-          data.br_data = unbr_str;
-        }
+        bool r = br_codec::brotli_decompress(reply, unbr_str_);
+        if (r)
+          data.resp_body = unbr_str_;
         else
           data.resp_body = reply;
 
@@ -2133,6 +2130,10 @@ class coro_http_client : public std::enable_shared_from_this<coro_http_client> {
 #endif
   content_encoding encoding_type_ = content_encoding::none;
 
+#ifdef CINATRA_ENABLE_BROTLI
+  std::string unbr_str_;
+#endif
+
 #ifdef BENCHMARK_TEST
   bool stop_bench_ = false;
   size_t total_len_ = 0;

diff --git a/tests/test_cinatra.cpp b/tests/test_cinatra.cpp
@@ -162,7 +162,7 @@ TEST_CASE("test brotli type") {
 
   auto result = async_simple::coro::syncAwait(client.async_post(
       "http://127.0.0.1:9001/get", ziped_str, req_content_type::none, headers));
-  CHECK(result.br_data == "ok");
+  CHECK(result.resp_body == "ok");
   server.stop();
 }
 #endif