-
Notifications
You must be signed in to change notification settings - Fork 56
Update SWxSOC Packages #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for this PR @Alrobbertz. I'm on vacation until the end of the month, so apologies that I won't get around to reviewing this until I'm back. But I'll look at it first thing in June. |
@Alrobbertz I'm back and I've reviewed your submission. The updates to SAMMI are good. SWxSOC seems like it will make a good PyHC package too, and after reviewing its repo I agree with your self evaluation. However, I have one request: are you able to unpin your boto3 version from |
Hi @sapols thank you for the review! We updated our requirements for |
@Alrobbertz excellent! Thanks for doing that so quickly. How soon will that release make it into PyPI? |
Unfortunately it looks like we're using an outdated release job in our GitHub actions. So I'll have to debug that and I'll let you know here once we're published. Also unfortunately we're using the same outdated release job for I think your PyHC Package template might have some baseline GitHub actions config that I can borrow ;) |
@Alrobbertz You’re one step ahead of me, I was gonna point you to it! https://github.com/heliophysicsPy/pyhc-repo-template/blob/main/.github/workflows/publish_to_pypi.yml I hope that’s a helpful starting point. Please let me know here once you’ve fixed it and the release is in PyPI? Then I’ll merge. |
Hi @sapols I fixed our release and published the latest version to PyPI. You should be able to find it here: https://pypi.org/project/swxsoc/ and install with |
Thanks @Alrobbertz! That looks great. However—and this is my bad—I just noticed swxsoc's requirement of parfive==2.1.0 also conflicts with the PyHC Environment... which requires Any chance swxsoc would work with If you're antsy to see it listed on PyHC's Projects page, we can merge this now and try resolving the environment conflict in a separate issue. But if you can bump that version easily, I'd appreciate doing that first. Please let me know? |
Hi @sapols , I don't think this should be an issue. I can bump the version and send another note when we have that published. Thank you for helping work through all this! |
No, thank you, @Alrobbertz! Sorry for giving you all the extra work. Looking forward to hearing back. |
Hi @sapols! I just updated our |
@Alrobbertz I'm happy to report this has been merged. SAMMI is updated, and swxsoc is now available in: Feel free to try it out! Thanks for everything. |
This PR:
swxsoc
package.