Skip to content

Conversation

Alrobbertz
Copy link
Contributor

This PR:

  • Updates some information for the SAMMI package
  • Adds the main swxsoc package.

@sapols
Copy link
Contributor

sapols commented May 13, 2025

Thanks for this PR @Alrobbertz. I'm on vacation until the end of the month, so apologies that I won't get around to reviewing this until I'm back. But I'll look at it first thing in June.

@sapols
Copy link
Contributor

sapols commented May 28, 2025

@Alrobbertz I'm back and I've reviewed your submission. The updates to SAMMI are good. SWxSOC seems like it will make a good PyHC package too, and after reviewing its repo I agree with your self evaluation.

However, I have one request: are you able to unpin your boto3 version from 1.35.26? i.e. make it any or >=1.35.0? I ask because that exact version requirement makes SWxSOC incompatible with the PyHC Environment. Long story short, due to dependencies from other PyHC packages, our environment requires botocore>=1.37.2,<1.37.4—which conflicts with boto3==1.35.26. If you cannot unpin that version, SWxSOC would be the only published PyHC package NOT in the environment which would be a shame.

@Alrobbertz
Copy link
Contributor Author

Hi @sapols thank you for the review! We updated our requirements for boto3>=1.35.26. Hopefully this will allow you to install the package in the PyHC environment!

swxsoc/swxsoc#34

@sapols
Copy link
Contributor

sapols commented May 29, 2025

@Alrobbertz excellent! Thanks for doing that so quickly. How soon will that release make it into PyPI?

@Alrobbertz
Copy link
Contributor Author

@Alrobbertz excellent! Thanks for doing that so quickly. How soon will that release make it into PyPI?

Unfortunately it looks like we're using an outdated release job in our GitHub actions. So I'll have to debug that and I'll let you know here once we're published.

Also unfortunately we're using the same outdated release job for sammi so I'll update that while I go as well.

I think your PyHC Package template might have some baseline GitHub actions config that I can borrow ;)

@sapols
Copy link
Contributor

sapols commented May 29, 2025

@Alrobbertz You’re one step ahead of me, I was gonna point you to it!

https://github.com/heliophysicsPy/pyhc-repo-template/blob/main/.github/workflows/publish_to_pypi.yml

I hope that’s a helpful starting point. Please let me know here once you’ve fixed it and the release is in PyPI? Then I’ll merge.

@Alrobbertz
Copy link
Contributor Author

Hi @sapols I fixed our release and published the latest version to PyPI. You should be able to find it here: https://pypi.org/project/swxsoc/ and install with pip install swxsoc

@sapols
Copy link
Contributor

sapols commented Jun 4, 2025

Thanks @Alrobbertz! That looks great.

However—and this is my bad—I just noticed swxsoc's requirement of parfive==2.1.0 also conflicts with the PyHC Environment... which requires parfive>=2.2.0. I'm sorry I didn't notice that before.

Any chance swxsoc would work with parfive>=2.1.0? Is there anything in v2.2.0 that breaks your code?

If you're antsy to see it listed on PyHC's Projects page, we can merge this now and try resolving the environment conflict in a separate issue. But if you can bump that version easily, I'd appreciate doing that first. Please let me know?

@Alrobbertz
Copy link
Contributor Author

Hi @sapols , I don't think this should be an issue. I can bump the version and send another note when we have that published.

Thank you for helping work through all this!

@sapols
Copy link
Contributor

sapols commented Jun 4, 2025

No, thank you, @Alrobbertz! Sorry for giving you all the extra work. Looking forward to hearing back.

@Alrobbertz
Copy link
Contributor Author

Hi @sapols! I just updated our parfive requirement to be parfive>=2.1.0 and published to PyPI. Let me know if you come across any other version mismatches!

@sapols sapols merged commit 0563561 into heliophysicsPy:main Jun 10, 2025
1 check passed
@sapols
Copy link
Contributor

sapols commented Jun 10, 2025

@Alrobbertz I'm happy to report this has been merged. SAMMI is updated, and swxsoc is now available in:

  1. PyHC's Projects page
  2. The PyHC Environment
  3. The PyHC Documentation Hub

Feel free to try it out! Thanks for everything.

@Alrobbertz Alrobbertz deleted the swxsoc_packages branch June 10, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants