-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nifty asset pages #294
Conversation
@febo is attempting to deploy a commit to the helius Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gm @febo, and thank you for the PR! I've gone ahead and deployed the branch to test it in my browser, and unfortunately, I'm getting a bunch of errors. When querying Can you please have a look into these errors? Everything else looks solid code-wise |
Hi @0xIchigo, thanks for having a look at it. On the first issue, I can't see any errors either on the server or client console. Is there a chance that you can post some of the type errors that you see? On the second issue, I noticed that the routing defaults to a "token" when it is not possible to determine the owner of the account here: https://github.com/helius-labs/xray/blob/dev/src/lib/xray/lib/search.ts#L64-L73 I did not want to change that logic, but perhaps the default should be to route to an |
gm @febo! This is the error when I get searching for For the second issue, feel free to change it to default to an account |
This is strange; can you provide the steps for duplication as I also don't see errors. What I'm doing:
I see some 429 errors but then it loads: |
Hi @0xIchigo Changed the default routing to For the type issues, we were not able to reproduce so not sure what could be the reason. The PR adds a new dependency |
gm @febo @samuelvanderwaal ! Thank you for your contributions! It seems like Vercel isn't building the branch correctly with the new dependency for the preview build, which is why the errors are being thrown. I'm going to go ahead and merge this PR and then test things out before merging to main. If I have any questions, I'll reach out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
This PR adds a page to show the details of
Asset
accounts from the Nifty Asset program, a lightweight open-source standard for non-fungible assets on Solana.Asset
accounts can store a variable amount of information on-chain in the form of extensions – the page shows all the information on the account.Details of the program can be found here: https://github.com/nifty-oss/asset
Here is the address of an asset on devnet:
DKejcqEdGRz6D5WupdC1GT6RmG4vH8qnnweXSasgxPiM
And here one on mainnet:
3WBnQbQwqe1NBNAgQUZXLv64b1uncBATWpthHyHgqgNP