Allow max number of files seen by file_picker to be configurable#5320
Allow max number of files seen by file_picker to be configurable#5320nstinus wants to merge 1 commit intohelix-editor:masterfrom
Conversation
|
Would it be a good idea to warn the user that the max number of files limit had been reached? Otherwise they might be looking for a file that exists that Helix would be hiding from them due to the At the moment the file picker opens with
|
|
I think both remarks make sense. I am also not convinced at the current state of affairs: why would a git tracked repo have no limit when a plain one has this arbitrary value. Surely, if there are too many files, the fact that we are in a git repo is irrelevant. Also, the issue with this approach is that I'd rather have a slow file_picker than not finding the file I am looking for... Perhaps an alternative could be to get rid of this value altogether and if the file_picker becomes slow, warn the user that there are a lot of files and it may be slow to use? |
|
@kirawi any thoughts on this ^ |
|
This was adreased by #7814, there is no limit anymore, files are streamed into the picker in the background now (and the matcher is fast enough to handle millions of files). |
Fixes #5157.
Follow up on #5165.