-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Night Quality Tracking #13
Open
minhchinh97h
wants to merge
14
commits into
master
Choose a base branch
from
feature/night-quality-tracking-merged
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey as date + update work on adding rating icon under daystrip
…ite tests & work on displaying ratings in charts
…ity only when logged in
… rating a night + only work when logged in + clean code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The merge request contains code implementation for developing a syncing feature for Night Ratings. There is a separate table in Dynamodb for holding only meta data about Night Quality of each night. The feature can only be used when logged in.
Also, the request contains fixes for existing unit-tests and for a minor bug causing unexpected crash.
This version of Night Quality is using Redux-thunk. React-query version is coming.
Fixes 2 (issues)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
There are unit-tests for Night Quality's reducer & actions.
Checklist: