Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Set Date and Time #162

Closed
bert003 opened this issue Apr 14, 2023 · 34 comments
Closed

Cannot Set Date and Time #162

bert003 opened this issue Apr 14, 2023 · 34 comments

Comments

@bert003
Copy link
Contributor

bert003 commented Apr 14, 2023

This is my first time using helloSystem. Please bare with me. I found the following issues:

  1. When trying to set the date, I get a message that Date and Time is not installed.

  2. When I install Chrome, it says it is installed but does not appear in the menu. Also the disk named chrome remains mounted and I cannot eject it.

How do you install additional software please?

@probonopd
Copy link
Member

Select "Chromium" from the System menu, it will ask you whether you want to download it.

@bert003
Copy link
Contributor Author

bert003 commented Apr 15, 2023

Thanks.

And what about the "Date and Time not installed" message please? Is there something else which I need to install?

@probonopd
Copy link
Member

Where do you see this message? Probably it is not implemented yet.

@bert003
Copy link
Contributor Author

bert003 commented Apr 15, 2023

I click the time on the top right (ex: 10:05 AM). It then displays the whole date: ex: Saturday, April 15, 2023 10:05:20 AM UTC. Then I click the whole date and it gives me this message as a pop-up:

The application 'Date and Time' can't be launched because it can't be found.

@probonopd
Copy link
Member

Yes, that application is not yet written.

@bert003
Copy link
Contributor Author

bert003 commented Apr 15, 2023

Noted. Thanks

@probonopd
Copy link
Member

probonopd commented Apr 15, 2023

Started making it:

image

Any volunteers want to work on it?
It's written in Python, so really simple to hack on.

https://github.com/helloSystem/Utilities/tree/master/Preferences/Date%20and%20Time.app

@bert003
Copy link
Contributor Author

bert003 commented Apr 15, 2023

Wow! Looks really nice. Appreciate your prompt support on this.

I am interested in working on it but I would need to learn how to program in Qt using Python in order to be able to help. I know Python already. Any templates for the helloSystem as a starting point please?

@probonopd
Copy link
Member

probonopd commented Apr 15, 2023

Check out https://hellosystem.github.io/docs/developer/applications.html
and the source code of the existing utilities at https://github.com/helloSystem/Utilities/

@bert003
Copy link
Contributor Author

bert003 commented Apr 15, 2023

Noted and visited the links provided. Please let me know where I can start from to contribute as regards application development.

@probonopd
Copy link
Member

Hi @bert003, I am not sure what exactly you are looking for, but I left some TODOs in the code:

# FIXME: The spinner is not shown; we need to fix this by using threading? Is there a better way?
# TODO: Implement manual time zone setting in the time zone tab
# TODO: Implement manual date and time setting in the date and time tab

In general, when you search for "TODO" and "FIXME" you'll find areas that could benefit greatly from contributions.

@bert003
Copy link
Contributor Author

bert003 commented Apr 16, 2023

Noted. Yes I just wanted to know in which applications is help needed. Ok let me have a look at the Date and Time Application.

Shall I create a personal fork of the project on my GitHub account? Or do you suggest another way? What about testing?

Sorry for asking a lot but would really like to contribute in the best possible way. Thanks for your time.

@probonopd
Copy link
Member

Ok let me have a look at the Date and Time Application.

Great!

Shall I create a personal fork of the project on my GitHub account?

Yes. And once you are satisfied with your changes, ping me so that I can test it.

Thanks. 👍

@bert003
Copy link
Contributor Author

bert003 commented Apr 23, 2023

Hi, excuse my late reply but had a tough week and could not work on this. I have forked the repository. When I do the changes, shall I commit directly to the master branch or create a new branch for the commit?

@probonopd
Copy link
Member

Hi @bert003, best make a separate branch with your changes, then ping me once you are happy with them. Thanks!

@bert003
Copy link
Contributor Author

bert003 commented Apr 23, 2023

Is there a way that I can test myself though before committing? Can I contact you separately in order not to spam this thread? Maybe I can get a sample template for the Date and Time app to test it Qt Design Studio?

@probonopd
Copy link
Member

Just make your changes in the code, then run the app by double-clicking it as usual.

@bert003
Copy link
Contributor Author

bert003 commented Apr 29, 2023

The spinner is appearing on the bottom left as shown below. Is that its intended position?

date-time-spinner

@probonopd
Copy link
Member

Well... not really. I hadn't thought about finding a position because I couldn't get it to work properly anyway.
At least we should make room for it, and the spinner could be half as large.

@probonopd probonopd transferred this issue from helloSystem/hello Apr 29, 2023
@bert003
Copy link
Contributor Author

bert003 commented Apr 29, 2023

I have created a pull request where I have implemented the spinner on both tabs. Have a look at it please and see if it is what you had in mind.

@probonopd
Copy link
Member

Looks good, but we need to make room for the spinner.

@bert003
Copy link
Contributor Author

bert003 commented Apr 29, 2023

What do you mean by "make room for the spinner" please?

Spinner should appear centered now (32px by 32px). At least it works on my environment (FreeBSD 13 + Python3.9), as shown below:

dt

@probonopd
Copy link
Member

Uh, that is strange. The spinner should not overlay existing controls.

We need to add some free space below the "Date and Time options" box, and have the spinner appear there.

@bert003
Copy link
Contributor Author

bert003 commented Apr 30, 2023

Ok noted. Creating a space underneath the button as shown below:

image

@bert003
Copy link
Contributor Author

bert003 commented Apr 30, 2023

Created a new pull request. I feel that the settings window should have a fixed size because when you resize, you end up with a lot of empty space. Feel free to amend as you wish.

@probonopd
Copy link
Member

Thank you very much. By the way, you should really test your version on helloSystem, as this is where the utilities will run...

@bert003
Copy link
Contributor Author

bert003 commented May 1, 2023

Welcome. Glad to be able to contribute. Did you have something in mind as regards the below?

TODO: Implement manual date and time setting in the date and time tab

@probonopd
Copy link
Member

I think this is a leftover, since one can now set the date and time manually.

@bert003
Copy link
Contributor Author

bert003 commented May 1, 2023

Ok noted.

I also found a bug in my code which I am going to correct soon and update the branch.

So what did you have in mind re: the below then please?

TODO: Implement manual time zone setting in the time zone tab

@probonopd
Copy link
Member

A drop down where I can select "Europe/Berlin" etc.

@bert003
Copy link
Contributor Author

bert003 commented May 2, 2023

Started implementing it. Requires pytz library.

image

@bert003
Copy link
Contributor Author

bert003 commented May 6, 2023

Auto Time Zone fully implemented and pushed to branch. I had to use geocoder and TimezoneFinder libraries to detect the user's time zone based on geolocation. Kindly check and revert at your convenience @probonopd

@bert003
Copy link
Contributor Author

bert003 commented May 27, 2023

Any feedback please? Should this be considered as implemented?

@probonopd
Copy link
Member

Thanks @bert003, let's continue the discussion in the PR at #163.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants