Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Date and Time, closes #162 #163

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bert003
Copy link
Contributor

@bert003 bert003 commented Apr 30, 2023

  • Made room for spinner under bottom-most buttons in each tab
  • Converted Main Window to fixed size since, as I see it, resizing will compromise its aesthetics

Implemented auto update of Date and Time and Time Zone including visible spinner
- Made room for spinner under bottom-most buttons in each tab
- Converted Main Window to fixed size since, as I see it, resizing will compromise its aesthetics
@probonopd probonopd changed the title bert003-patch-3 Update Date and Time, closes #162 Apr 30, 2023
Implemented Automatic Time Zone Setting and corrected minor bugs
@probonopd
Copy link
Member

Hi @bert003.

Did you test whether this works on a plain helloSystem Live ISO with no additional software installed?

import pytz
import geocoder

Where are those supposed to be coming from? There are two options:

  • Bundle them in the AppDir
  • Preinstall them on the helloSystem ISO

Which way should we go?

@louies0623

This comment was marked as duplicate.

@Hierosme
Copy link

i would like to take a look on #165 , it look like a good way is to split UI / Model / Controller (ha ha ha Hierosme my heros ...)

i joking a bit but maintain a App over the time force that split. If we convert Date and Time to a true .ui file it force very bad day for the #162 fixe.

Here my plan:

  • Create git branch call FIXE/165
  • Fork the Date and Time.app inside Under Contruction directory
  • Convert the App to a .ui and (Yes that a start of the split in direction to a pure MVC style)
  • Isolate the code dedicated to the Gui
  • Isolate the code it have to touch the system
  • Create central data set in charge make action with the system (Yes a Backend)
  • Toogle Lock/Unlock the backend with a one click action
  • Permit a 100% setting view on Read Only
  • Only when unlock the backend try to speack with isolate systen code
  • Make a true Cross platform code (Yes code like that can help a lot other projects)

Hoooo noooo Hierosme got a plan
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants