Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade some icon #226

Open
wants to merge 147 commits into
base: master
Choose a base branch
from
Open

Upgrade some icon #226

wants to merge 147 commits into from

Conversation

louies0623
Copy link
Contributor

@louies0623 louies0623 commented Oct 8, 2023

Redesign some icons and reduce the capacity occupied by the icon size.

@louies0623
Copy link
Contributor Author

@Hierosme
Could you please replace "os.path.dirname" directly with "os.path.join"? For example, this paragraph.
This
self.setPixmap(QtWidgets.QWizard.BackgroundPixmap, QtGui.QPixmap(os.path.dirname(__file__) + '/Welcome.png'))
to
self.setPixmap(QtWidgets.QWizard.BackgroundPixmap, QtGui.QPixmap(os.path.join (__file__) + '/Welcome.png'))

@louies0623
Copy link
Contributor Author

louies0623 commented Oct 30, 2023

@probonopd Most of the icons have been replaced. As for the modification of the code, I am sorry that I am not capable enough. You may need to modify it later.

@Hierosme
Copy link

Hierosme commented Feb 10, 2024

@Hierosme Could you please replace "os.path.dirname" directly with "os.path.join"? For example, this paragraph. This self.setPixmap(QtWidgets.QWizard.BackgroundPixmap, QtGui.QPixmap(os.path.dirname(__file__) + '/Welcome.png')) to self.setPixmap(QtWidgets.QWizard.BackgroundPixmap, QtGui.QPixmap(os.path.join (__file__) + '/Welcome.png'))

If fact no:

os.path.join() join a list for create a cross platform path by determine the value of os.path.sep ( / or \)
od.path.dirname() is coupled with file_ get the true directory where is store the py file it self.

From my point the syntax should be

logo_pixmap = QtGui.QPixmap(
    os.path.join(
        os.path.dirname(__file__) ,
        'failed.png'
)).scaledToHeight(256, QtCore.Qt.SmoothTransformation)

@Hierosme
Copy link

Hierosme commented Feb 14, 2024

Any news of it pull request ?
@louies0623 have make a huge work and a merge is require from my point.

The image path it not a trouble, i can open an other MR and fixe every pure style path trouble.
Pure style is not a issue, when it work it work ...

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants