Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilities/Zeroconf.app: Use dns-sd instead of avahi-browse #57

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Utilities/Zeroconf.app: Use dns-sd instead of avahi-browse #57

wants to merge 17 commits into from

Commits on Mar 25, 2021

  1. Move zeroconf tool into Resources/zeroconf.py 

    - This will make it easier to write unit tests later.
- This is consistent with the example set in Utilities/Calculator.app.
- ./Zeroconf is now just a shell script pointing to the Python
  application.
    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    cbf2b17 View commit details
    Browse the repository at this point in the history

  2. ZeroconfBrowser: Remove new-style class syntax 

    In Python 2, there were old-style classes (`class Foo:`) and new-style
classes (`class Foo(object):`). This is not necessary in Python 3.
    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    adaea29 View commit details
    Browse the repository at this point in the history

  3. ZeroconfBrowser.quit(): call self.app.quit() not sys.exit() 

    This means that the self.app.aboutToQuit signal will be processed, and
the application can clean up after itself.
    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    1247a01 View commit details
    Browse the repository at this point in the history

  4. ZeroconfService: Rewrite class 

    A simple class representing a service, with some unused fields left out,
and with no handle() method.
    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    5082097 View commit details
    Browse the repository at this point in the history

  5. ZeroconfService: Add unit tests

    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    b037d74 View commit details
    Browse the repository at this point in the history

  6. ZeroconfService: Allow testing for equality between instances 

    This will be useful when we want to remove services from the list or
avoid adding duplicates.
    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    7b118e7 View commit details
    Browse the repository at this point in the history

  7. CommandReader: Add class 

    It runs a command using QProcess and emits each line of the output
through a pyqtSignal.
    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    a8091ef View commit details
    Browse the repository at this point in the history

  8. CommandReader: Add unit tests

    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    ee70c48 View commit details
    Browse the repository at this point in the history

  9. ZeroconfDiscoverer: Add class 

    This class discovers services on the local network by running `dns-sd`.
    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    7a114fb View commit details
    Browse the repository at this point in the history

  10. ZeroconfDiscoverer: Clean up all QProcesses on quit 

    This means the tool no longer leaves several `dns-sd` processes running
in the background.
    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    a504903 View commit details
    Browse the repository at this point in the history

  11. ZeroconfServices & ZeroconfBrowser: Hook them up 

    The recently added/modified classes behave differently from the old ones
- so hook things up.
    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    02088b5 View commit details
    Browse the repository at this point in the history

  12. ZeroconfServices: Do not add duplicates

    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    aa3046c View commit details
    Browse the repository at this point in the history

  13. ZeroconfServices: Handle removing items from the list 

    I don't know how to remove a PyQt5 widget entirely, so I used
setHidden(true).
    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    acc2875 View commit details
    Browse the repository at this point in the history

  14. ZeroconfBrowser.onDoubleClicked(): Fix to work with new self.services 

    - self.services changed slightly in the previous commit, so the method
  has been updated to handle that.
- DRY.
    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    7d0ff8c View commit details
    Browse the repository at this point in the history

  15. ZeroconfServices: Add a doc string

    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    b842e66 View commit details
    Browse the repository at this point in the history

  16. sshLogin: Add a doc string

    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    1a1a85e View commit details
    Browse the repository at this point in the history

  17. ZeroconfBrowser: Add a doc string

    @MalloryA
    MalloryA committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    d02d295 View commit details
    Browse the repository at this point in the history