Feat/add-golang-lint #623
Merged
Feat/add-golang-lint #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Obinna Odirionye <[email protected]>
Signed-off-by: Obinna Odirionye <[email protected]>
Signed-off-by: Obinna Odirionye <[email protected]>
…, Import should be Stdlib, third party and other packages of this project. Signed-off-by: Obinna Odirionye <[email protected]>
Signed-off-by: Obinna Odirionye <[email protected]>
Signed-off-by: Obinna Odirionye <[email protected]>
Signed-off-by: Obinna Odirionye <[email protected]>
Signed-off-by: Obinna Odirionye <[email protected]>
cbuto
approved these changes
Sep 19, 2022
|
@cbuto I am confused; my commits are signed, and DCO did not throw any error. Kindly assist me. |
You have to setup a key that will be used for signing commits, there are some docs here that describe how to generate a new key and setup git to sign commits with that key. It's required in addition to the DCO signoff. |
|
Hey, @scbizu, Can I go ahead and merge this PR? I wanted to take a look at it before merging. |
|
@nerdeveloper Please do the |
nerdeveloper
force-pushed
the
feat/golang-lint
branch
2 times, most recently
from
be7c101 to
75605e5
Compare
|
@scbizu done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #569