HIP 0027: Handling unknown hook-delete-policy values #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcin Owsiany <[email protected]>
Signed-off-by: Marcin Owsiany <[email protected]>
|
can you look at this? |
joejulian
reviewed
Sep 25, 2025
Comment on lines
+67
to
+84
| #### 1. Official support for a policy which disables hook deletion | ||
|
|
||
| Add a new, documented hook deletion policy value: `never`. | ||
| When specified, such hook resource is not deleted. | ||
| Effectively, the same as suggestion for Helm 3, but explicitly supported. | ||
|
|
||
| Pros: | ||
| - Keeps compatibility with Helm 3. | ||
| - Allows a notion of resources which are installed by helm, but afterwards not managed by it in any way. | ||
| - StackRox chart continues to work as before without changing. | ||
| - Other charts (if any) which happen depend on current undocumented behaviour could easily be made to work by changing | ||
| whatever value they use to `never`. | ||
|
|
||
| Cons: | ||
| - It seems that hooks were generally intended to be resources whose previous instances are cleaned up | ||
| before (subsequent) chart applications. Supporting this policy breaks this assumption and | ||
| introduces some complexity when reasoning about possible scenarios. For example such `pre-install` | ||
| hook resources need to be guarded by a `if $.Release.IsInstall` condition in order not to break upgrades. |
There was a problem hiding this comment.
I prefer this one and would call it a bug fix. I think the con you listed, while valid, is probably the expected behavior for anyone that was previously using a not-supported string. This would just make it more explicit.
joejulian
reviewed
Sep 25, 2025
Comment on lines
+124
to
+130
| Add a linter check that complains if an undocumented value for hook deletion policy is used. | ||
|
|
||
| Pros: | ||
| - Raises awareness about this issue. | ||
|
|
||
| Cons: | ||
| - None? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.