Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimistic Concurrency Pt.1 #834

Merged
merged 124 commits into from
Sep 28, 2024
Merged

Optimistic Concurrency Pt.1 #834

merged 124 commits into from
Sep 28, 2024

Conversation

FoseFx
Copy link
Member

@FoseFx FoseFx commented Sep 17, 2024 •
edited
Loading

First Steps for #808

  • Return Consistency Token
    • CreatePropertyResponse
    • GetPropertyResponse
    • GetPropertiesBySubjectTypeResponse
    • GetAttachedPropertyValuesResponse
    • GetBedResponse
    • GetBedByPatientResponse
    • GetBedsResponse
    • GetBedsByRoomResponse
    • GetPatientResponse
    • GetPatientByBedResponse
    • GetPatientsByWardResponse
    • GetPatientAssignmentByWardResponse
    • GetPatientDetailsResponse
    • GetPatientListResponse
    • GetRecentPatientsResponse
    • GetRoomResponse
    • GetRoomsResponse
    • GetRoomOverviewsByWardResponse
    • GetTaskResponse
    • GetTasksByPatientResponse
    • GetTasksByPatientSortedByStatusResponse
    • GetAssignedTasksResponse
    • GetAllTaskTemplatesResponse
    • GetWardResponse
    • GetWardsResponse
    • GetRecentWardsResponse
    • GetWardDetailsResponse
    • GetWardOverviewsResponse
    • CreateBedRequest
    • BulkCreateBedsResponse (not implemented?)
    • CreatePatientRequest
    • CreateRoomResponse
    • CreateTaskRequest
    • CreateSubtaskResponse
    • CreateTaskTemplateResponse
    • CreateTaskTemplateSubTaskResponse
    • UpdatePropertyResponse
    • AttachPropertyValueResponse
    • UpdateBedResponse
    • UpdatePatientResponse
    • AssignBedResponse
    • UnassignBedResponse
    • DischargePatientResponse
    • ReadmitPatientResponse
    • UpdateRoomResponse
    • UpdateTaskRequest
    • AssignTaskResponse
    • UnassignTaskResponse
    • UpdateSubtaskResponse
    • RemoveTaskDueDateResponse
    • UpdateTaskTemplateResponse
    • UpdateTaskTemplateSubTaskResponse
  • Make sure all projections update the consistency
    • ward_repo.sql
    • bed_repo.sql
    • task_repo.sql
    • room_repo.sql
    • task_template_repo.sql
    • patient_repo.sql
    • property_repo.sql
    • property_value

@FoseFx FoseFx self-assigned this Sep 17, 2024
FoseFx added 28 commits September 17, 2024 16:03
@FoseFx
add conflicting_attributes
b94d108
@FoseFx
here we go
f69a0e7
@FoseFx
Merge branch 'main' into issue/808-optimistic
ae95c30
@FoseFx
fix import issues
9f70e65
@FoseFx
test passes
10fbf22
@FoseFx
add more consistency updates
581ec16
@FoseFx
remove unused query
3c3f09d
@FoseFx
update consistency on option remove
cfa36f9
@FoseFx
one down
2db09e3
@FoseFx
GetPropertiesBySubjectType
d1143b0
@FoseFx
GetAttachedPropertyValuesResponse
59ecb86
@FoseFx
GetBed
b4598d0
@FoseFx
GetBedByPatient
1957652
@FoseFx
GetBedsByRoom
afc5d77
@FoseFx
GetRoom
8860546
@FoseFx
more endpoints
e9609d8
@FoseFx
GetPatientListResponse
996fbb2
@FoseFx
GetRooms
697832d
@FoseFx
GetRoomOverviewsByWard
a56696d
@FoseFx
GetRecentPatients
6fbd679
@FoseFx
GetTaskResponse
a06c080
@FoseFx
GetTasksByPatient
649d355
@FoseFx
GetTasksByPatientSortedByStatusResponse
b572c36
@FoseFx
GetAssignedTasksResponse
26078ef
@FoseFx
GetWardResponse
cb92168
@FoseFx
GetWards
0e2b06c
@FoseFx
an attempt to make the voices stop
3fcce0d 
that's what I call the linter
@FoseFx
GetRecentWardsResponse
86c3ad1
MaxSchaefer
MaxSchaefer requested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@MaxSchaefer MaxSchaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review still in progress. 162 of 261 files.

libs/hwes/aggregate_store.go Outdated Show resolved Hide resolved
libs/hwes/eventstoredb/aggregate_store.go Outdated Show resolved Hide resolved
libs/hwtesting/containers.go Outdated Show resolved Hide resolved
services/tasks-svc/stories/TaskTemplateCRUD_test.go Outdated Show resolved Hide resolved
MaxSchaefer
MaxSchaefer requested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@MaxSchaefer MaxSchaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in scope of this pr but whats your opinion about an own type definition for the consistency tokens instead of uint64?

services/tasks-svc/stories/RoomCRUD_test.go Outdated Show resolved Hide resolved
services/tasks-svc/stories/RoomCRUD_test.go Outdated Show resolved Hide resolved
services/tasks-svc/stories/RoomCRUD_test.go Outdated Show resolved Hide resolved
services/tasks-svc/stories/RoomCRUD_test.go Outdated Show resolved Hide resolved
services/tasks-svc/stories/TaskCRUD_test.go Outdated Show resolved Hide resolved
services/tasks-svc/stories/WardCRUD_test.go Outdated Show resolved Hide resolved
services/tasks-svc/stories/WardCRUD_test.go Outdated Show resolved Hide resolved
services/tasks-svc/stories/WardCRUD_test.go Outdated Show resolved Hide resolved
services/tasks-svc/stories/WardCRUD_test.go Outdated Show resolved Hide resolved
services/property-svc/stories/GetPropertieBySubjectType_test.go Show resolved Hide resolved
@MaxSchaefer
Copy link
Member

261/261

MaxSchaefer
MaxSchaefer requested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@MaxSchaefer MaxSchaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All touched Proto definitions needs to be backwards compatible. Many Proto changes of this PR are introducing a non-optional param "consistency". This param needs to be optional.

Examples

FoseFx and others added 10 commits September 28, 2024 08:59
@FoseFx @MaxSchaefer
update services/tasks-svc/stories/RoomCRUD_test.go
7fbc499 
Co-authored-by: Max Schäfer <[email protected]>
@FoseFx @MaxSchaefer
update services/tasks-svc/stories/RoomCRUD_test.go
f414d98 
Co-authored-by: Max Schäfer <[email protected]>
@FoseFx @MaxSchaefer
update services/tasks-svc/stories/TaskCRUD_test.go
8de2dbf 
Co-authored-by: Max Schäfer <[email protected]>
@FoseFx @MaxSchaefer
update services/tasks-svc/stories/WardCRUD_test.go
5a33772 
Co-authored-by: Max Schäfer <[email protected]>
@FoseFx @MaxSchaefer
Update services/tasks-svc/stories/RoomCRUD_test.go
c9598e7 
Co-authored-by: Max Schäfer <[email protected]>
@FoseFx @MaxSchaefer
Update services/tasks-svc/stories/RoomCRUD_test.go
6d64723 
Co-authored-by: Max Schäfer <[email protected]>
@FoseFx @MaxSchaefer
Update services/tasks-svc/stories/TaskTemplateCRUD_test.go
6f4828d 
Co-authored-by: Max Schäfer <[email protected]>
@FoseFx @MaxSchaefer
Update services/tasks-svc/stories/WardCRUD_test.go
d7d85b5 
Co-authored-by: Max Schäfer <[email protected]>
@FoseFx @MaxSchaefer
Update services/tasks-svc/stories/WardCRUD_test.go
2bcfd65 
Co-authored-by: Max Schäfer <[email protected]>
@FoseFx @MaxSchaefer
Update services/tasks-svc/stories/WardCRUD_test.go
2afd473 
Co-authored-by: Max Schäfer <[email protected]>
@FoseFx
Copy link
Member Author

FoseFx commented Sep 28, 2024

All touched Proto definitions needs to be backwards compatible. Many Proto changes of this PR are introducing a non-optional param "consistency". This param needs to be optional.

Examples

I just went through all message changes again, requests only got new optional fields. Responses got new mandatory strings, because the backend must provide them. (Clients are free to ignore it though)

@FoseFx
Copy link
Member Author

FoseFx commented Sep 28, 2024

Not in scope of this pr but whats your opinion about an own type definition for the consistency tokens instead of uint64?

Very much in scope, and a very good idea!

@FoseFx FoseFx requested a review from MaxSchaefer September 28, 2024 07:55
MaxSchaefer
MaxSchaefer approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@MaxSchaefer MaxSchaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stay consistent 🤟

@FoseFx FoseFx merged commit dcc524f into main Sep 28, 2024
45 checks passed
@FoseFx FoseFx deleted the issue/808-optimistic branch October 20, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxSchaefer MaxSchaefer MaxSchaefer approved these changes

@PaulKalho PaulKalho Awaiting requested review from PaulKalho PaulKalho is a code owner automatically assigned from helpwave/backend

Assignees

@FoseFx FoseFx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FoseFx @MaxSchaefer