-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: publishing non event-sourced events #884
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxSchaefer
force-pushed
the
more-events
branch
3 times, most recently
from
November 8, 2024 18:13
bdd42de
to
dc39d8d
Compare
MaxSchaefer
force-pushed
the
more-events
branch
from
November 8, 2024 18:19
dc39d8d
to
0c92a75
Compare
MaxSchaefer
requested review from
FoseFx and
PaulKalho
and removed request for
a team
November 11, 2024 13:49
FoseFx
reviewed
Nov 11, 2024
FoseFx
reviewed
Nov 13, 2024
FoseFx
reviewed
Nov 14, 2024
This was referenced Nov 17, 2024
MaxSchaefer
force-pushed
the
more-events
branch
from
November 17, 2024 23:25
26f9f4e
to
4557f40
Compare
FoseFx
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables our event to be defined in proto message. An event message contains the option
libs.events.v1.event_type
. This option gets evaluated by our event logic to resolve the event type directly from the proto defintion.I also introduce the concept of an EntityEvent. Those events are quickly raised events in non event sourced services.