Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update linting #1150

Merged
merged 11 commits into from
Jan 9, 2025
Merged

update linting #1150

merged 11 commits into from
Jan 9, 2025

Conversation

DasProffi
Copy link
Member

Which issues does this pull request close?

closes #1100

[OPTIONAL] Give testing instructions to reviewers

@DasProffi DasProffi self-assigned this Dec 27, 2024
@DasProffi DasProffi requested a review from a team as a code owner December 27, 2024 18:47
@DasProffi DasProffi requested review from ChrisKulesza and felixevers and removed request for a team December 27, 2024 18:47
Copy link

cloudflare-workers-and-pages bot commented Dec 27, 2024

Deploying web with  Cloudflare Pages  Cloudflare Pages

Latest commit: edd9cd2
Status: ✅  Deploy successful!
Preview URL: https://9312d1ac.web-d91.pages.dev
Branch Preview URL: https://issue-1100-no-empty-then.web-d91.pages.dev

View logs

@MaxSchaefer
Copy link
Member

MaxSchaefer commented Jan 9, 2025

I am poking around locally, when running pnpm run lint inside tasks/ I get a tsc error. Can you reproduce this?

❯ pnpm run lint

> @helpwave/[email protected] lint /Users/maxrs/Projects/helpwave/helpwave-web/tasks
> eslint . && tsc --noEmit


Oops! Something went wrong! :(

ESLint: 9.17.0

ConfigError: Config (unnamed): Key "rules": Key "constructor-super": structuredClone is not defined
    at rethrowConfigError (/Users/maxrs/Projects/helpwave/helpwave-web/node_modules/.pnpm/@[email protected]/node_modules/@eslint/config-array/dist/cjs/index.cjs:328:8)
    at /Users/maxrs/Projects/helpwave/helpwave-web/node_modules/.pnpm/@[email protected]/node_modules/@eslint/config-array/dist/cjs/index.cjs:1174:5
    at Array.reduce (<anonymous>)
    at FlatConfigArray.getConfigWithStatus (/Users/maxrs/Projects/helpwave/helpwave-web/node_modules/.pnpm/@[email protected]/node_modules/@eslint/config-array/dist/cjs/index.cjs:1167:43)
    at FlatConfigArray.getConfig (/Users/maxrs/Projects/helpwave/helpwave-web/node_modules/.pnpm/@[email protected]/node_modules/@eslint/config-array/dist/cjs/index.cjs:1196:15)
    at entryFilter (/Users/maxrs/Projects/helpwave/helpwave-web/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/eslint/eslint-helpers.js:282:40)
    at async NodeHfs.<anonymous> (file:///Users/maxrs/Projects/helpwave/helpwave-web/node_modules/.pnpm/@[email protected]/node_modules/@humanfs/core/src/hfs.js:574:24)
    at async NodeHfs.<anonymous> (file:///Users/maxrs/Projects/helpwave/helpwave-web/node_modules/.pnpm/@[email protected]/node_modules/@humanfs/core/src/hfs.js:604:6)
    at async NodeHfs.walk (file:///Users/maxrs/Projects/helpwave/helpwave-web/node_modules/.pnpm/@[email protected]/node_modules/@humanfs/core/src/hfs.js:614:3)
    at async globSearch (/Users/maxrs/Projects/helpwave/helpwave-web/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/eslint/eslint-helpers.js:323:26)

@DasProffi DasProffi merged commit 59b56df into main Jan 9, 2025
10 checks passed
@DasProffi DasProffi deleted the issue/1100-no-empty-then branch January 9, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace empty .then() with .catch() and error logging
2 participants