Skip to content

Added Japanese translations #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 3, 2023
Merged

Added Japanese translations #14

merged 5 commits into from
Aug 3, 2023

Conversation

kuragehimekurara1
Copy link
Contributor

No description provided.

@henkelmax henkelmax self-assigned this Aug 1, 2023
@henkelmax
Copy link
Owner

I can't find the language code ja_ryu anywhere. Are you sure thats an actual language Minecraft supports?

@henkelmax henkelmax self-requested a review August 2, 2023 10:07
henkelmax
henkelmax requested changes Aug 2, 2023
View reviewed changes
Copy link
Owner

@henkelmax henkelmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ja_ryu does not seem to be a valid language code

@kuragehimekurara1
Copy link
Contributor Author

Sorry for the late response. Deleted ja_ryu files.

@kuragehimekurara1 kuragehimekurara1 changed the title Added Japanese and Uchinaguchi translations Added Japanese translations Aug 3, 2023
@henkelmax henkelmax self-requested a review August 3, 2023 10:09
@henkelmax henkelmax merged commit c0a4cbe into henkelmax:master Aug 3, 2023
henkelmax added a commit that referenced this pull request Aug 3, 2023
@henkelmax
Update version and changelog for #14
77c5789
@henkelmax
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henkelmax henkelmax henkelmax approved these changes

Assignees

@henkelmax henkelmax

Labels
translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuragehimekurara1 @henkelmax