style(code-review): adds the respective code review corrections as di…

…rected
henkkelder · Sep 30, 2016 · 6b415f6 · 6b415f6
1 parent adafc8f
commit 6b415f6
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 10 deletions.
diff --git a/.jshintrc b/.jshintrc
@@ -5,15 +5,14 @@
   "indent": 2,
   "predef": [
     "document",
-    "window",
-    "define",
-    "module"
+    "window"
   ],
   "browser": true,
   "boss": true,
   "curly": true,
   "debug": false,
   "devel": true,
+  "eqeqeq": true,
   "expr": true,
   "validthis": true,
   "evil": true,

diff --git a/src/inputjs/compute-delta-xy.js b/src/inputjs/compute-delta-xy.js
@@ -1,8 +1,10 @@
-import { INPUT_START,INPUT_END } from './input-consts';
+import { INPUT_START, INPUT_END } from './input-consts';
 
 export default function computeDeltaXY(session, input) {
   let { center } = input;
-  let offset = session.offsetDelta || {}; // could be further deconstructed later on
+  // let { offsetDelta:offset = {}, prevDelta = {}, prevInput = {} } = session;
+  // jscs throwing error on defalut destructured values and without defaults tests fail
+  let offset = session.offsetDelta || {};
   let prevDelta = session.prevDelta || {};
   let prevInput = session.prevInput || {};
 

diff --git a/src/inputjs/compute-input-data.js b/src/inputjs/compute-input-data.js
@@ -35,8 +35,7 @@ export default function computeInputData(manager, input) {
     session.firstMultiple = false;
   }
 
-  let { firstInput } = session;
-  let { firstMultiple } = session;
+  let { firstInput, firstMultiple } = session;
   let offsetCenter = firstMultiple ? firstMultiple.center : firstInput.center;
 
   let center = input.center = getCenter(pointers);

diff --git a/src/main.js b/src/main.js
@@ -126,6 +126,7 @@ assign(Hammer, {
 let freeGlobal = (typeof window !== 'undefined' ? window : (typeof self !== 'undefined' ? self : {})); // jshint ignore:line
 freeGlobal.Hammer = Hammer;
 
+/* jshint ignore:start */
 if (typeof define === 'function' && define.amd) {
   define(function() {
     return Hammer;
@@ -135,3 +136,4 @@ if (typeof define === 'function' && define.amd) {
 } else {
   window[exportName] = Hammer;
 }
+/* jshint ignore:end */
diff --git a/src/recognizers/swipe.js b/src/recognizers/swipe.js
@@ -36,7 +36,7 @@ inherit(SwipeRecognizer, AttrRecognizer, {
   },
 
   attrTest(input) {
-    let { options:{ direction } } = this;
+    let { direction } = this.options;
     let velocity;
 
     if (direction & (DIRECTION_HORIZONTAL | DIRECTION_VERTICAL)) {

diff --git a/src/utils/utils-consts.js b/src/utils/utils-consts.js
@@ -3,8 +3,7 @@ const TEST_ELEMENT = document.createElement('div');
 
 const TYPE_FUNCTION = 'function';
 
-const { round } = Math;
-const { abs } = Math;
+const { round, abs } = Math;
 const { now } = Date;
 
 export {