Repository navigation
fix: disk sizes like Finder and power on Macs without a battery - #114
Merged
Merged
Conversation
Disk capacity, free and used space use decimal units and count purgeable space as available. The Overview Disk card shows activity throughout, and the Disk page gains a used-versus-free bar. A Mac without a battery gets a Power page with system, GPU and per-app power, and no Battery choices in settings.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5a2857c02
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
On a Mac without a battery a saved battery tile now shows as Power, and the last-tile check in Settings counts only the tiles on offer.
# Conflicts: # CHANGELOG.md # src/settings.rs # src/ui.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disk sizes
fmt_disk_bytes: Overview card, Disk page and device detail, panel tile, nearly-full finding and alert. Memory stays binary. The menu-bar disk readout and widget export show rates and percentages only, so they are unchanged.NSURLVolumeAvailableCapacityForImportantUsageKeyfor/(Finder's available, purgeable included) and falls back to statfs when absent, zero or larger than the disk.Power without a battery
Verification