lseek: Fixed incorrect lseek behaviour with whence Set or Cur #1934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had buggy code that was using lseek.
Turns out, FUSE is a little odd in that regard (I might be wrong, but this is how it looks to me):
preadv64
internally)Lseek
does exist in FUSE and in virtiofsd it maps to the host'slseek
. It also returns the host'slseek
return value.lseek
with aCur
whence doesn't return a meaningful value.lseek
to the deamon is not sufficient for seeking through a file (we already use an internal offset correctly in these cases).This PR fixes the incorrect behaviour in lseek by:
Set
andCur
.This should have a slightly positive effect on the performance, since it reduces virtio transactions.
Note that this is not tested for
Data
andHole
, so these might still be buggy.