find_kernel: initialize the allocator based on the start address for unrelocatable kernels #378
+16
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unrelocatable kernels
mkroening
requested changes
Oct 14, 2024
There was a problem hiding this comment.
I am not sure why initializing PhysAlloc after the mapping works, as the mapping functions seem to depend on it.
That is only true if there are no additional page tables (and thus physical frames) needed to perform the mapping. See Mapper::map_to_with_table_flags
We are also moving away from unrelocatable kernels. We now support relocatable GCC-based kernels: hermit-os/hermit-entry#37
|
We are not interested in supporting any feature that is not needed by hermit, right? In that case we can remove the part for adjusting the start address based on the ELF object. Should we still add a check to see if the kernel expects to be located at a certain address and error if that's the case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure why initializing PhysAlloc after the mapping works, as the mapping functions seem to depend on it.