Iter rework

[an-owl]

pr for #19

• Defined AddrIter to panic when iterating over non-canonical addresses.
• Implemented DoubleEndedIterator and ExactSizeIterator
• Added a number of method implementations for iterator traits to reduce unnecessary calls to Iterator::next()
• Added an inclusive variant of the iterator. This is required because it cannot return the last address in a range without it. (e.g it will never return 0x7FFFFFFFFFFF it will stop at 0x7FFFFFFFFFFE).
• Added From<Range> and From<RangeInclusive> for AddrIter

8637ae6 requires that MemoryAddress::RAW implements TryFrom<usize>, I don't really like further restricting it but it already implements TryInto<usize> so it probably wont be an issue.

There may be bugs where iterating to a non-canonical address when add/sub_checked() returns None, by assuming its an overflow, when it should be checked. I think I caught them all but there might be more.

[jounathaen]

Minor nitpicks: Could you please add a doc comment to these pub items? Also, the line spacing is a little inconsistent.

[jounathaen]

Very nice! Thank you for the contribution!

[an-owl]

Sorry for the wait. I've added docs to the pub items with some doctests too which managed to catch a bug.

I also added some code comments where I thought they were necessary.

[jounathaen]

Very nice! Once Clippy is satisfied, I'm as well 😉

I assume you are interested in a release after the merge?

[an-owl]

I assume you are interested in a release after the merge?

Not yet there are still a couple of things I want to add.

[jounathaen]

@an-owl, can you fix the Clippy issue? Then I'd be happy to merge this :-)

[jounathaen]

Ah, I didn't notice the fix. Thank you for your contribution!

[jounathaen]

Released: https://crates.io/crates/memory_addresses/0.2.4