Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ingestion #64

Merged
merged 10 commits into from
Dec 16, 2024
Merged

feat: ingestion #64

merged 10 commits into from
Dec 16, 2024

Conversation

marco-ippolito
Copy link
Member

This features allows customer to send their package.json.
Bikeshedding or error messages, prompts, naming welcome 😄

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Nov 22, 2024

Apparently the errors are caused by Apollo client not being supported in Node v14 and v16

Copy link
Contributor

@jeremymwells jeremymwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small suggestion.

Also wondering if we should either 1) take a directory as a flag, or 2) prompt the user to run in the root of the project. Apologize if I've missed that.

Copy link
Member

@dwelch2344 dwelch2344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Few thoughts/suggestions. Alll are up for debate (minus the url config and user-agent bit)

@marco-ippolito
Copy link
Member Author

@marco-ippolito marco-ippolito force-pushed the ingestion branch 2 times, most recently from 0a56671 to c4e592c Compare November 22, 2024 15:28
@marco-ippolito
Copy link
Member Author

Also wondering if we should either 1) take a directory as a flag, or 2) prompt the user to run in the root of the project. > Apologize if I've missed that.

I'd add that as next step and pass it as argument like -c ./foo/bar

@marco-ippolito marco-ippolito force-pushed the ingestion branch 3 times, most recently from 9839f5b to 4d48bb8 Compare November 23, 2024 11:10
Copy link
Contributor

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments/suggestions. Otherwise lgtm 👍

@marco-ippolito marco-ippolito force-pushed the ingestion branch 2 times, most recently from 9718bb0 to 146d4e0 Compare December 11, 2024 12:40
@marco-ippolito
Copy link
Member Author

It breaks v14 and v16 💀 trying to investigate

@marco-ippolito marco-ippolito force-pushed the ingestion branch 5 times, most recently from 76fd748 to 87626db Compare December 11, 2024 17:27
@marco-ippolito
Copy link
Member Author

basically in pre-18 node versions there is no fetch and apollo client does not work but throws weird errors. Adding isomorphic-fetch fixes this

@marco-ippolito marco-ippolito merged commit e5fa36c into herodevs:main Dec 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants