[Godot 4] Add support for delete_account_sync() and other API changes that were added in Nakama v3.15.0 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added in Nakama v3.15.0
lugehorsam
reviewed
Jan 30, 2023
| var _authoritative | ||
| var authoritative : bool: | ||
| get: | ||
| return false if not _authoritative is bool else bool(_authoritative) |
There was a problem hiding this comment.
is there a GDScript equivalent for something just like _return authoritative?
There was a problem hiding this comment.
The code generator does these type checks for some reason. I suspect it was to avoid errors and just return false if _authoritative contains something other than bool? If it just did return _authoritative and it wasn't bool, there'd be a fatal error.
We could certainly change the code generator to produce less verbose code, but that would affect everything in the NakamaAPI.gd file, and that seems like it probably deserves it's own separate PR.
lugehorsam
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Godot 4 version of PR #146