Adjust default sort order for leaderboards in admin command

heroiclabs · Mar 24, 2017 · 10bb86d · 10bb86d
1 parent 76ac761
commit 10bb86d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cmd/admin.go b/cmd/admin.go
@@ -61,7 +61,7 @@ func createLeaderboard(args []string, logger zap.Logger) {
 	flags.StringVar(&dsns, "db", "root@localhost:26257", "CockroachDB JDBC connection details.")
 	flags.StringVar(&id, "id", "", "ID to assign to the leaderboard.")
 	flags.BoolVar(&authoritative, "authoritative", false, "True if clients may not submit scores directly, false otherwise.")
-	flags.StringVar(&sortOrder, "sort", "descending", "Leaderboard sort order, 'asc' or 'desc'.")
+	flags.StringVar(&sortOrder, "sort", "desc", "Leaderboard sort order, 'asc' or 'desc'.")
 	flags.StringVar(&resetSchedule, "reset", "", "Optional reset schedule in CRON format.")
 	flags.StringVar(&metadata, "metadata", "{}", "Optional additional metadata as a JSON string.")
 

diff --git a/server/pipeline_group.go b/server/pipeline_group.go
@@ -354,7 +354,7 @@ func (p *pipeline) groupsFetch(logger zap.Logger, session *session, envelope *En
 	case *TGroupsFetch_GroupIds_:
 		for _, gid := range g.GetGroupIds().GroupIds {
 			groupID, err := uuid.FromBytes(gid)
-			if err != nil {
+			if err == nil {
 				params = append(params, groupID.Bytes())
 				statements = append(statements, "id = $"+strconv.Itoa(len(params)))
 			}