Skip to content

Commit

Permalink
Update changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
sesposito committed Sep 6, 2023
1 parent 7201428 commit e0204d4
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 8 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@ The format is based on [keep a changelog](http://keepachangelog.com) and this pr

## [Unreleased]
### Fixed
- Fixed multiple issues found by linter.
- Fix linter-found test issue.
- Fix storage index listing results sometimes being returned with incorrect order.

### Changed
- Add create_time and update_time to returned storage engine writes acks.
- Add storage index create flag to read only from the index.

### [3.17.1] - 2023-08-23
### Added
Expand Down
4 changes: 2 additions & 2 deletions server/api_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ func NewConsoleLogger(output *os.File, verbose bool) *zap.Logger {
}

func NewDB(t *testing.T) *sql.DB {
// db, err := sql.Open("pgx", "postgresql://[email protected]:26257/nakama?sslmode=disable")
db, err := sql.Open("pgx", "postgresql://postgres:[email protected]:5432/nakama?sslmode=disable")
db, err := sql.Open("pgx", "postgresql://[email protected]:26257/nakama?sslmode=disable")
//db, err := sql.Open("pgx", "postgresql://[email protected]:5432/nakama?sslmode=disable")
if err != nil {
t.Fatal("Error connecting to database", err)
}
Expand Down
10 changes: 5 additions & 5 deletions server/storage_index.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import (
"encoding/json"
"errors"
"fmt"
"google.golang.org/protobuf/types/known/timestamppb"
"time"

"github.com/blugelabs/bluge"
Expand All @@ -29,6 +28,7 @@ import (
"github.com/gofrs/uuid/v5"
"github.com/heroiclabs/nakama-common/api"
"go.uber.org/zap"
"google.golang.org/protobuf/types/known/timestamppb"
"google.golang.org/protobuf/types/known/wrapperspb"
)

Expand Down Expand Up @@ -508,28 +508,28 @@ func (si *LocalStorageIndex) queryMatchesToStorageIndexResults(dmi search.Docume
idxResult.Version = string(value)
case "read":
read, vErr := bluge.DecodeNumericFloat64(value)
if err != nil {
if vErr != nil {
err = vErr
return false
}
idxResult.Read = int32(read)
case "write":
read, vErr := bluge.DecodeNumericFloat64(value)
if err != nil {
if vErr != nil {
err = vErr
return false
}
idxResult.Write = int32(read)
case "create_time":
createTime, vErr := bluge.DecodeDateTime(value)
if err != nil {
if vErr != nil {
err = vErr
return false
}
idxResult.CreateTime = createTime
case "update_time":
updateTime, vErr := bluge.DecodeDateTime(value)
if err != nil {
if vErr != nil {
err = vErr
return false
}
Expand Down

0 comments on commit e0204d4

Please sign in to comment.