WriteTournamentScore now updates num_scores even if submitted score is not an improvement #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not an improvement Previously if a score was not an improvement the WHERE clause on the update query would prevent the num_scores from being updated, this would also cause an issue with the rank cache not correctly deleting the previous score, since the values of the old scores are only retrieved if the query succeds, meaning values would get added multiple times.
|
|
flaviofernandes004
approved these changes
Nov 10, 2023
|
Thanks @robtraynor! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a score was not an improvement the WHERE clause on the update query would prevent the num_scores from being updated, this would also cause an issue with the rank cache not correctly deleting the previous score, since the values of the old scores are only retrieved if the query succeds, meaning values would get added multiple times.
This should fix #1124