Skip to content

Conversation

sesposito
Copy link
Member

No description provided.

@sesposito sesposito force-pushed the spe/socket-closure-handling branch 2 times, most recently from 0c112ad to 54d2881 Compare August 13, 2025 12:45
@sesposito sesposito force-pushed the spe/socket-closure-handling branch from 54d2881 to 075982d Compare August 13, 2025 12:55
@sesposito sesposito marked this pull request as ready for review August 20, 2025 15:59
@sesposito sesposito requested review from Copilot and zyro August 20, 2025 15:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves WebSocket connection closure handling by implementing a graceful shutdown process that properly handles the WebSocket close handshake. The changes ensure the server waits for client acknowledgment when initiating a close operation.

  • Disables the default close handler to allow custom close message processing
  • Implements a timeout-based wait for client close acknowledgment when server initiates closure
  • Updates logging to provide more context about the closure reason

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@heroiclabs heroiclabs deleted a comment from 22TOXIC-WASTE22 Aug 22, 2025
@sesposito sesposito force-pushed the spe/socket-closure-handling branch from ae61669 to b82a816 Compare August 26, 2025 19:27
@sesposito sesposito merged commit e6828b1 into master Aug 29, 2025
7 of 8 checks passed
@sesposito sesposito deleted the spe/socket-closure-handling branch August 29, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants