Skip to content

Update Rust minimum version to 1.86#117

Merged
schneems merged 2 commits intomainfrom
schneems/msrv-1.86
Jul 1, 2025
Merged

Update Rust minimum version to 1.86#117
schneems merged 2 commits intomainfrom
schneems/msrv-1.86

Conversation

@schneems
Copy link
Contributor

@schneems schneems commented Jul 1, 2025

More details in this PR to bullet_stream heroku-buildpacks/bullet_stream#47. And this comment reporting the issue #110 (comment).

The short version is: This buildpack uses a dependency that accidentally uses a feature stabilized in Rust 1.86, but it didn't correctly update the minimum required Rust version. If it had, when #115 was merged, it would have also triggered the change that's now being made (I'm guessing this field is not linted, but I've not verified). This change corrects the problem by correctly stating the minimum Rust version so all dependencies can compile correctly.

GUS-W-18939940

More details in this PR to bullet_stream heroku-buildpacks/bullet_stream#47. And this comment reporting the issue #110 (comment).

The short version is: This buildpack uses a dependency that accidentally uses a feature stabilized in Rust 1.86, but it didn't correctly update the minimum required Rust version. If it had, when #115 was merged, it would have also triggered the change that's now being made (I'm guessing this field is not linted, but I've not verified). This change corrects the problem by correctly stating the minimum Rust version so all dependencies can compile correctly.
@schneems schneems marked this pull request as ready for review July 1, 2025 14:29
@schneems schneems requested a review from a team as a code owner July 1, 2025 14:29
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Signed-off-by: Richard Schneeman <richard.schneeman+no-recruiters@gmail.com>
@schneems schneems enabled auto-merge (squash) July 1, 2025 16:18
@schneems schneems merged commit a89c4d9 into main Jul 1, 2025
6 checks passed
@schneems schneems deleted the schneems/msrv-1.86 branch July 1, 2025 16:21
heroku-linguist bot added a commit that referenced this pull request Jul 3, 2025
## heroku/deb-packages

### Added

- Support custom Debian repositories through configuration. ([#116](#116))

### Changed

- Minimum supported Rust version incremented to 1.86 to support syntax introduced in [#115](#115). ([#117](#117))
@heroku-linguist heroku-linguist bot mentioned this pull request Jul 3, 2025
heroku-linguist bot added a commit to heroku/cnb-builder-images that referenced this pull request Jul 3, 2025
## heroku/deb-packages

### Added

- Support custom Debian repositories through configuration. ([#116](heroku/buildpacks-deb-packages#116))

### Changed

- Minimum supported Rust version incremented to 1.86 to support syntax introduced in [#115](heroku/buildpacks-deb-packages#115). ([#117](heroku/buildpacks-deb-packages#117))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants