Switch to setup-node@v4, clean up warnings

heroku · Aug 27, 2024 · edbf30a · edbf30a
1 parent ba899f2
commit edbf30a
Show file tree

Hide file tree

Showing 12 changed files with 15 additions and 15 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -13,7 +13,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           cache: yarn
@@ -36,7 +36,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           cache: yarn
@@ -59,7 +59,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           cache: yarn
@@ -84,7 +84,7 @@ jobs:
         with: 
           fetch-depth: 0
       - name: Use Node.js
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
       - run: yarn add [email protected]

diff --git a/.github/workflows/promote-windows.yml b/.github/workflows/promote-windows.yml
@@ -32,7 +32,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Use Node.js 20.x
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 20.x
           cache: yarn

diff --git a/.github/workflows/promote.yml b/.github/workflows/promote.yml
@@ -45,7 +45,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Use Node.js 20.x
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 20.x
           cache: yarn

diff --git a/.github/workflows/publish-npm.yml b/.github/workflows/publish-npm.yml
@@ -34,7 +34,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Use Node.js 20.x
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 20.x
           cache: yarn

diff --git a/.github/workflows/publish-to-fig-autocomplete.yml b/.github/workflows/publish-to-fig-autocomplete.yml
@@ -10,7 +10,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Use Node.js 20.x
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 20.x
           cache: yarn

diff --git a/.github/workflows/snyk.yml b/.github/workflows/snyk.yml
@@ -13,7 +13,7 @@ jobs:
       SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
           node-version: 20.x
       - run: yarn --immutable --network-timeout 1000000

diff --git a/.github/workflows/start-prerelease.yml b/.github/workflows/start-prerelease.yml
@@ -41,7 +41,7 @@ jobs:
       TAG_NAME: ${{ format('v{0}', needs.get-version-channel.outputs.version) }}
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
           node-version: 20.x
       - name: set git user

diff --git a/.github/workflows/tag-create-github-release.yml b/.github/workflows/tag-create-github-release.yml
@@ -20,7 +20,7 @@ jobs:
         with:
           ssh-private-key: ${{ secrets.SSH_RELEASE_PRIVATE_KEY }}
       - name: Use Node.js 20.x
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 20.x
           cache: yarn

diff --git a/.github/workflows/test-installed-cli.yml b/.github/workflows/test-installed-cli.yml
@@ -22,7 +22,7 @@ jobs:
       HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }}
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
           node-version: '20.x'
           registry-url: 'https://registry.npmjs.org'

diff --git a/packages/cli/src/commands/access/index.ts b/packages/cli/src/commands/access/index.ts
@@ -78,7 +78,7 @@ export default class AccessIndex extends Command {
   }
 
   public async run(): Promise<void> {
-    const {flags, argv, args} = await this.parse(AccessIndex)
+    const {flags} = await this.parse(AccessIndex)
     const {app: appName, json} = flags
     const {body: app} = await this.heroku.get<Heroku.App>(`/apps/${appName}`)
     let {body: collaborators} = await this.heroku.get<Heroku.TeamAppCollaborator[]>(`/apps/${appName}/collaborators`)

diff --git a/packages/cli/src/commands/buildpacks/info.ts b/packages/cli/src/commands/buildpacks/info.ts
@@ -19,7 +19,7 @@ export default class Info extends Command {
     const registry = new BuildpackRegistry()
 
     Result.match({
-      Ok: _ => {},
+      Ok: () => {},
       Err: err => {
         this.error(`Could not publish the buildpack.\n${err}`)
       },

diff --git a/packages/cli/src/commands/buildpacks/versions.ts b/packages/cli/src/commands/buildpacks/versions.ts
@@ -24,7 +24,7 @@ export default class Versions extends Command {
     const registry = new BuildpackRegistry()
 
     Result.match({
-      Ok: _ => {},
+      Ok: () => {},
       Err: err => {
         this.error(`Could not find the buildpack.\n${err}`)
       },